Re: [Qemu-devel] [PATCH v2] qga: Add support network interface statistics in guest-network-get-interfaces command

[Eric Blake]

On 04/20/2017 08:14 AM, Eric Blake wrote:

>> @@ -648,7 +673,8 @@
>>  { 'struct': 'GuestNetworkInterface',
>>    'data': {'name': 'str',
>>             '*hardware-address': 'str',
>> -           '*ip-addresses': ['GuestIpAddress'] } }
>> +           '*ip-addresses': ['GuestIpAddress'],
>> +           '*interface-statics': ['GuestNetworkInterfaceStat'] } }
> 
> s/interface-statics/statistics/ (the 'interface-' prefix is redundant,
> and you typo'd the remaining portion of the name)
> 
> Missing documentation, including a (since 2.10) tag.

More specifically, I'm expecting a line like:

# @statistics: various statistic counters related to the interface
(since 2.10)

Which makes me think that you want this to be:
'*statistics':'GuestNetworkInterfaceStat'

that is, you want it to be a single struct, not an array of structs.  An
array of GuestIpAddress makes sense (a single guest interface can have
multiple IP addresses), but an array of statistics does not (the
interface only has one counter of how many packets were transmitted).

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature