[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 14/14] error: Apply error_propagate_null.cocci again
From: |
Fam Zheng |
Subject: |
[Qemu-devel] [PATCH 14/14] error: Apply error_propagate_null.cocci again |
Date: |
Fri, 21 Apr 2017 20:27:10 +0800 |
Signed-off-by: Fam Zheng <address@hidden>
---
hw/i386/pc.c | 4 +---
hw/s390x/virtio-ccw.c | 4 +---
hw/usb/bus.c | 4 +---
3 files changed, 3 insertions(+), 9 deletions(-)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index d24388e..f3b372a 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1104,9 +1104,7 @@ static void pc_new_cpu(const char *typename, int64_t
apic_id, Error **errp)
object_property_set_bool(cpu, true, "realized", &local_err);
object_unref(cpu);
- if (local_err) {
- error_propagate(errp, local_err);
- }
+ error_propagate(errp, local_err);
}
void pc_hot_add_cpu(const int64_t id, Error **errp)
diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c
index 00b3bde..ba4979c 100644
--- a/hw/s390x/virtio-ccw.c
+++ b/hw/s390x/virtio-ccw.c
@@ -1757,9 +1757,7 @@ static void vhost_vsock_ccw_realize(VirtioCcwDevice
*ccw_dev, Error **errp)
qdev_set_parent_bus(vdev, BUS(&ccw_dev->bus));
object_property_set_bool(OBJECT(vdev), true, "realized", &err);
- if (err) {
- error_propagate(errp, err);
- }
+ error_propagate(errp, err);
}
static void vhost_vsock_ccw_class_init(ObjectClass *klass, void *data)
diff --git a/hw/usb/bus.c b/hw/usb/bus.c
index 24f1608..5939b27 100644
--- a/hw/usb/bus.c
+++ b/hw/usb/bus.c
@@ -762,9 +762,7 @@ static void usb_set_attached(Object *obj, bool value, Error
**errp)
if (value) {
usb_device_attach(dev, &err);
- if (err) {
- error_propagate(errp, err);
- }
+ error_propagate(errp, err);
} else {
usb_device_detach(dev);
}
--
2.9.3
- [Qemu-devel] [PATCH 05/14] block: Make errp the last parameter of bdrv_img_create, (continued)
- [Qemu-devel] [PATCH 05/14] block: Make errp the last parameter of bdrv_img_create, Fam Zheng, 2017/04/21
- [Qemu-devel] [PATCH 06/14] crypto: Make errp the last parameter of functions, Fam Zheng, 2017/04/21
- [Qemu-devel] [PATCH 07/14] mirror: Make errp the last parameter of mirror_start_job, Fam Zheng, 2017/04/21
- [Qemu-devel] [PATCH 08/14] block: Make errp the last parameter of commit_active_start, Fam Zheng, 2017/04/21
- [Qemu-devel] [PATCH 09/14] nfs: Make errp the last parameter of nfs_client_open, Fam Zheng, 2017/04/21
- [Qemu-devel] [PATCH 11/14] scsi: Make errp the last parameter of virtio_scsi_common_realize, Fam Zheng, 2017/04/21
- [Qemu-devel] [PATCH 10/14] fdc: Make errp the last parameter of fdctrl_connect_drives, Fam Zheng, 2017/04/21
- [Qemu-devel] [PATCH 12/14] migration: Make errp the last parameter of local functions, Fam Zheng, 2017/04/21
- [Qemu-devel] [PATCH 13/14] qga: Make errp the last parameter of qga_vss_fsfreeze, Fam Zheng, 2017/04/21
- [Qemu-devel] [PATCH 14/14] error: Apply error_propagate_null.cocci again,
Fam Zheng <=
- Re: [Qemu-devel] [PATCH 00/14] Trivial cleanups around error reporting, Eric Blake, 2017/04/21
- Re: [Qemu-devel] [PATCH 00/14] Trivial cleanups around error reporting, Markus Armbruster, 2017/04/22
- Re: [Qemu-devel] [PATCH 00/14] Trivial cleanups around error reporting, Markus Armbruster, 2017/04/24