[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v2 11/12] block/rbd: Add support for reopen()
From: |
Jeff Cody |
Subject: |
[Qemu-devel] [PULL v2 11/12] block/rbd: Add support for reopen() |
Date: |
Mon, 24 Apr 2017 15:20:01 -0400 |
This adds support for reopen in rbd, for changing between r/w and r/o.
Note, that this is only a flag change, but we will block a change from
r/o to r/w if we are using an RBD internal snapshot.
Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Jeff Cody <address@hidden>
Reviewed-by: John Snow <address@hidden>
Message-id: address@hidden
---
block/rbd.c | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/block/rbd.c b/block/rbd.c
index 35853c9..6471f4f 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -668,6 +668,26 @@ failed_opts:
return r;
}
+
+/* Since RBD is currently always opened R/W via the API,
+ * we just need to check if we are using a snapshot or not, in
+ * order to determine if we will allow it to be R/W */
+static int qemu_rbd_reopen_prepare(BDRVReopenState *state,
+ BlockReopenQueue *queue, Error **errp)
+{
+ BDRVRBDState *s = state->bs->opaque;
+ int ret = 0;
+
+ if (s->snap && state->flags & BDRV_O_RDWR) {
+ error_setg(errp,
+ "Cannot change node '%s' to r/w when using RBD snapshot",
+ bdrv_get_device_or_node_name(state->bs));
+ ret = -EINVAL;
+ }
+
+ return ret;
+}
+
static void qemu_rbd_close(BlockDriverState *bs)
{
BDRVRBDState *s = bs->opaque;
@@ -1074,6 +1094,7 @@ static BlockDriver bdrv_rbd = {
.bdrv_parse_filename = qemu_rbd_parse_filename,
.bdrv_file_open = qemu_rbd_open,
.bdrv_close = qemu_rbd_close,
+ .bdrv_reopen_prepare = qemu_rbd_reopen_prepare,
.bdrv_create = qemu_rbd_create,
.bdrv_has_zero_init = bdrv_has_zero_init_1,
.bdrv_get_info = qemu_rbd_getinfo,
--
2.9.3
- [Qemu-devel] [PULL v2 00/12] Block patches, Jeff Cody, 2017/04/24
- [Qemu-devel] [PULL v2 04/12] block: add bdrv_set_read_only() helper function, Jeff Cody, 2017/04/24
- [Qemu-devel] [PULL v2 03/12] qemu-iotests: exclude vxhs from image creation via protocol, Jeff Cody, 2017/04/24
- [Qemu-devel] [PULL v2 06/12] block: honor BDRV_O_ALLOW_RDWR when clearing bs->read_only, Jeff Cody, 2017/04/24
- [Qemu-devel] [PULL v2 05/12] block: do not set BDS read_only if copy_on_read enabled, Jeff Cody, 2017/04/24
- [Qemu-devel] [PULL v2 02/12] block/vxhs.c: Add qemu-iotests for new block device type "vxhs", Jeff Cody, 2017/04/24
- [Qemu-devel] [PULL v2 01/12] block/vxhs.c: Add support for a new block device type called "vxhs", Jeff Cody, 2017/04/24
- [Qemu-devel] [PULL v2 08/12] block: introduce bdrv_can_set_read_only(), Jeff Cody, 2017/04/24
- [Qemu-devel] [PULL v2 07/12] block: code movement, Jeff Cody, 2017/04/24
- [Qemu-devel] [PULL v2 09/12] block: use bdrv_can_set_read_only() during reopen, Jeff Cody, 2017/04/24
- [Qemu-devel] [PULL v2 11/12] block/rbd: Add support for reopen(),
Jeff Cody <=
- [Qemu-devel] [PULL v2 12/12] qemu-iotests: _cleanup_qemu must be called on exit, Jeff Cody, 2017/04/24
- [Qemu-devel] [PULL v2 10/12] block/rbd - update variable names to more apt names, Jeff Cody, 2017/04/24
- Re: [Qemu-devel] [PULL v2 00/12] Block patches, Peter Maydell, 2017/04/25