Re: [Qemu-devel] [PATCH] Issue a deprecation warning if the user specifies the "-hdachs" option.

[Eric Blake]

On 04/25/2017 03:08 AM, Thomas Huth wrote:
> If the user needs to specify the disk geometry, the corresponding
> parameters of the "-drive" option should be used instead. "-hdachs"
> is considered as deprecated and might be removed soon.
> 
> Signed-off-by: Thomas Huth <address@hidden>
> ---
>  vl.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/vl.c b/vl.c
> index 0b4ed52..0980213 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3230,6 +3230,8 @@ int main(int argc, char **argv, char **envp)
>                          }
>                      }
>                  }
> +                error_report("'-hdachs' is deprecated. Please use '-drive"
> +                             " ...,cyls=c,heads=h,secs=s,trans=t' instead.");

No trailing dot.  With that fixed,
Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature