Re: [Qemu-devel] [PATCH 1/9] Add ppc.risu file

[G 3]

On Apr 25, 2017, at 4:14 AM, Peter Maydell wrote:

> On 25 April 2017 at 04:17, G 3 <address@hidden> wrote:
> > Add the ppc.risu file. It defines the format for various PowerPC
> > instructions.
> >
> > Signed-off-by: John Arbuckle <address@hidden>
> > ---
> >  ppc.risu | 527
> > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 527 insertions(+)
> >  create mode 100644 ppc.risu
> >
> > diff --git a/ppc.risu b/ppc.risu
> > new file mode 100644
> > index 0000000..b6d6aee
> > --- /dev/null
> > +++ b/ppc.risu
> > @@ -0,0 +1,527 @@
> > +#################################################################### 
> > ###########
> > +# File: ppc.risu
> > +# Date: 3-27-2017
> > +# Description: Specifies PowerPC instruction test patterns.
> > +#################################################################### 
> > ###########
>
> Missing copyright and license statement.
>
> > +
> > +.mode ppc
> > +
> > +# Note: register r1 cannot be used because it is the stack pointer.
> > +# The branching, VEA, and OEA instructions cannot be used here  
> > currently.
> > +
> > +ADD PPC 011111 rD:5 rA:5 rB:5 OE:1 100001010 Rc:1 \
> > +!constraints { $rD != 1 && $rA != 1 && $rB != 1; }
> > +
> > +ADDC PPC 011111 rD:5 rA:5 rB:5 OE:1 000001010 Rc:1 \
> > +!constraints { $rD != 1 && $rA != 1 && $rB != 1; }
> > +
> > +ADDE PPC 011111 rD:5 rA:5 rB:5 OE:1 010001010 Rc:1 \
> > +!constraints { $rD != 1 && $rA != 1 && $rB != 1; }
>
>
> There's an awful lot of duplication with ppc64 here. Is it
> worth trying to share?
>
>
> thanks
> -- PMM

That would be difficult. There are a lot of new instructions in ppc64  
that don't exist in ppc32.