[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 5/9] tmp backend: Add new api to read backend
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 5/9] tmp backend: Add new api to read backend TpmInfo |
Date: |
Tue, 25 Apr 2017 13:59:34 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 |
On 04/25/2017 01:51 PM, Stefan Berger wrote:
>> +++ b/qapi-schema.json
>> @@ -5140,6 +5140,16 @@
>> { 'command': 'query-tpm-types', 'returns': ['TpmType'] }
>>
>> ##
>> +# @TPMOptions:
>> +#
>> +# Base type for TPM options
>> +#
>> +# Since: 2.10
>> +##
>> +{ 'struct': 'TPMOptions',
>> + 'data': { } }
>> +
>> +##
>> # @TPMPassthroughOptions:
>> #
>> # Information about the TPM passthrough type
>> @@ -5151,20 +5161,9 @@
>> #
>> # Since: 1.5
>> ##
>> -{ 'struct': 'TPMPassthroughOptions', 'data': { '*path' : 'str',
>> - '*cancel-path' : 'str'} }
>> +{ 'struct': 'TPMPassthroughOptions', 'base': 'TPMOptions',
>> + 'data': { '*path' : 'str', '*cancel-path' : 'str'} }
>
>
> I don't think that you can change it like this anymore since this is
> part of the public interface.
The change is backwards compatible; it doesn't break any existing QMP
usage. It's weird to have an empty base class, though.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 1/9] tpm-backend: Remove unneeded member variable from backend class, (continued)
- [Qemu-devel] [PATCH v2 1/9] tpm-backend: Remove unneeded member variable from backend class, Amarnath Valluri, 2017/04/07
- [Qemu-devel] [PATCH v2 2/9] tpm-backend: Move thread handling inside TPMBackend, Amarnath Valluri, 2017/04/07
- [Qemu-devel] [PATCH v2 4/9] tpm-backend: Made few interface methods optional, Amarnath Valluri, 2017/04/07
- [Qemu-devel] [PATCH v2 6/9] tpm-backend: Remove unneeded destroy() method from TpmDriverOps interface, Amarnath Valluri, 2017/04/07
- [Qemu-devel] [PATCH v2 5/9] tmp backend: Add new api to read backend TpmInfo, Amarnath Valluri, 2017/04/07
- [Qemu-devel] [PATCH v2 7/9] tpm-backend: Move realloc_buffer() implementation to base class, Amarnath Valluri, 2017/04/07
- [Qemu-devel] [PATCH v2 8/9] tpm-passthrough: move reusable code to utils, Amarnath Valluri, 2017/04/07
- [Qemu-devel] [PATCH v2 9/9] tpm: Added support for TPM emulator, Amarnath Valluri, 2017/04/07