[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 10/11] block: Fix bdrv_co_flush early return
|
From: |
Fam Zheng |
|
Subject: |
Re: [Qemu-devel] [PULL 10/11] block: Fix bdrv_co_flush early return |
|
Date: |
Wed, 26 Apr 2017 08:19:12 +0800 |
|
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Tue, 04/25 16:00, Peter Maydell wrote:
>
> Coverity points out that there's a problem here -- we call
> bdrv_inc_in_flight(bs), which assumes bs is not NULL, before
> we do the test for whether bs is NULL.
>
> Presumably the NULL check needs to be pulled up earlier in
> the function?
>
Yes, will take care of this one.
Fam
- [Qemu-devel] [PULL 03/11] tests/block-job-txn: Don't start block job before adding to txn, (continued)
- [Qemu-devel] [PULL 03/11] tests/block-job-txn: Don't start block job before adding to txn, Fam Zheng, 2017/04/11
- [Qemu-devel] [PULL 04/11] coroutine: Extract qemu_aio_coroutine_enter, Fam Zheng, 2017/04/11
- [Qemu-devel] [PULL 05/11] async: Introduce aio_co_enter, Fam Zheng, 2017/04/11
- [Qemu-devel] [PULL 06/11] block: Introduce bdrv_coroutine_enter, Fam Zheng, 2017/04/11
- [Qemu-devel] [PULL 07/11] blockjob: Use bdrv_coroutine_enter to start coroutine, Fam Zheng, 2017/04/11
- [Qemu-devel] [PULL 08/11] qemu-io-cmds: Use bdrv_coroutine_enter, Fam Zheng, 2017/04/11
- [Qemu-devel] [PULL 09/11] block: Use bdrv_coroutine_enter to start I/O coroutines, Fam Zheng, 2017/04/11
- [Qemu-devel] [PULL 11/11] sheepdog: Use bdrv_coroutine_enter before BDRV_POLL_WHILE, Fam Zheng, 2017/04/11
- [Qemu-devel] [PULL 10/11] block: Fix bdrv_co_flush early return, Fam Zheng, 2017/04/11
- Re: [Qemu-devel] [PULL 00/11] Block patches for 2.9-rc4, Peter Maydell, 2017/04/11