qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] net/dump: Issue a warning for the deprecated "-


From: Jason Wang
Subject: Re: [Qemu-devel] [PATCH] net/dump: Issue a warning for the deprecated "-net dump"
Date: Wed, 26 Apr 2017 17:25:12 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0



On 2017年04月25日 15:50, Thomas Huth wrote:
Network dumping should be done with "-object filter-dump" nowadays.
Using "-net dump" via the VLAN mechanism is considered as deprecated
and might be removed in a future release. So warn the users now
to inform them to user the filter-dump method instead.

Signed-off-by: Thomas Huth <address@hidden>
---
  net/dump.c | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/net/dump.c b/net/dump.c
index 89a149b..442eb53 100644
--- a/net/dump.c
+++ b/net/dump.c
@@ -194,6 +194,9 @@ int net_init_dump(const Netdev *netdev, const char *name,
assert(peer); + error_report("'-net dump' is deprecated. "
+                 "Please use '-object filter-dump' instead.");
+
      if (dump->has_file) {
          file = dump->file;
      } else {

Applied.

Thanks



reply via email to

[Prev in Thread] Current Thread [Next in Thread]