[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 0/3] split core mmu_idx from ARMMMUIdx values
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [RFC 0/3] split core mmu_idx from ARMMMUIdx values |
Date: |
Wed, 26 Apr 2017 11:17:28 +0100 |
On 26 April 2017 at 11:07, Richard Henderson <address@hidden> wrote:
> On 04/24/2017 06:33 PM, Peter Maydell wrote:
>>
>> Overall questions:
>> * does this look like it's workable enough to justify taking
>> it rather than the simple-but-worse-perf-on-some-archs
>> option 1 ?
>
>
> I think it's workable.
Yes, I think I agree overall.
>> * this does risk breaking A profile in corner cases, because
>> C unfortunately doesn't typecheck int vs enum so if I forgot
>> a call to an index conversion function somewhere things will
>> break. are we happy the risk isn't too huge?
>
>
> If you like, we could add a tcg_debug assert somewhere that verifies that
> the given index is < NB_MMU_MODES...
There is one already, because in my testing I ran into it.
The problem is that since it's a runtime assert, it's not
certain that I caught everything.
thanks
-- PMM
- [Qemu-devel] [RFC 0/3] split core mmu_idx from ARMMMUIdx values, Peter Maydell, 2017/04/24
- [Qemu-devel] [RFC 1/3] arm: Use the mmu_idx we're passed in arm_cpu_do_unaligned_access(), Peter Maydell, 2017/04/24
- [Qemu-devel] [RFC 3/3] arm: Use different ARMMMUIdx values for M profile, Peter Maydell, 2017/04/24
- [Qemu-devel] [RFC 2/3] arm: Add support for M profile CPUs having different MMU index semantics, Peter Maydell, 2017/04/24
- Re: [Qemu-devel] [Qemu-arm] [RFC 0/3] split core mmu_idx from ARMMMUIdx values, Peter Maydell, 2017/04/24
- Re: [Qemu-devel] [RFC 0/3] split core mmu_idx from ARMMMUIdx values, Richard Henderson, 2017/04/26
- Re: [Qemu-devel] [RFC 0/3] split core mmu_idx from ARMMMUIdx values,
Peter Maydell <=