Re: [Qemu-devel] [PATCH v3 05/18] crypto: cipher: add cipher driver framework

[Daniel P. Berrange]

On Sat, Apr 22, 2017 at 03:20:14PM +0800, Longpeng(Mike) wrote:
> 1) makes the public APIs in cipher-nettle/gcrypt/builtin static,
>    and rename them with "nettle/gcrypt/builtin" prefix.
> 
> 2) introduces cipher framework, including QCryptoCipherDriver
>    and new public APIs.
> 
> Reviewed-by: Gonglei <address@hidden>
> Signed-off-by: Longpeng(Mike) <address@hidden>
> ---
>  crypto/cipher-builtin.c | 64 +++++++++++++++++--------------------------
>  crypto/cipher-gcrypt.c  | 72 
> +++++++++++++++++++++----------------------------
>  crypto/cipher-nettle.c  | 71 ++++++++++++++++++++----------------------------
>  crypto/cipher.c         | 65 ++++++++++++++++++++++++++++++++++++++++++++
>  crypto/cipherpriv.h     | 40 +++++++++++++++++++++++++++
>  include/crypto/cipher.h |  1 +
>  6 files changed, 190 insertions(+), 123 deletions(-)
>  create mode 100644 crypto/cipherpriv.h

Reviewed-by: Daniel P. Berrange <address@hidden>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|