[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 08/18] crypto: hmac: introduce qcrypto_hmac_c
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH v3 08/18] crypto: hmac: introduce qcrypto_hmac_ctx_new for gcrypt-backend |
Date: |
Wed, 26 Apr 2017 13:05:46 +0100 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Sat, Apr 22, 2017 at 03:20:17PM +0800, Longpeng(Mike) wrote:
> 1) Fix a handle-leak problem in qcrypto_hmac_new(), doesn't free
> ctx->handle if gcry_mac_setkey fails.
>
> 2) Extracts qcrypto_hmac_ctx_new() from qcrypto_hmac_new() for
> gcrypt-backend impls.
>
> Reviewed-by: Gonglei <address@hidden>
> Signed-off-by: Longpeng(Mike) <address@hidden>
> ---
> crypto/hmac-gcrypt.c | 35 +++++++++++++++++++++++++----------
> 1 file changed, 25 insertions(+), 10 deletions(-)
Reviewed-by: Daniel P. Berrange <address@hidden>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [Qemu-devel] [PATCH v3 00/18] crypto: add afalg-backend support, Longpeng(Mike), 2017/04/22
- [Qemu-devel] [PATCH v3 01/18] crypto: cipher: introduce context free function, Longpeng(Mike), 2017/04/22
- [Qemu-devel] [PATCH v3 07/18] crypto: hmac: move crypto/hmac.h into include/crypto/, Longpeng(Mike), 2017/04/22
- [Qemu-devel] [PATCH v3 08/18] crypto: hmac: introduce qcrypto_hmac_ctx_new for gcrypt-backend, Longpeng(Mike), 2017/04/22
- Re: [Qemu-devel] [PATCH v3 08/18] crypto: hmac: introduce qcrypto_hmac_ctx_new for gcrypt-backend,
Daniel P. Berrange <=
- [Qemu-devel] [PATCH v3 02/18] crypto: cipher: introduce qcrypto_cipher_ctx_new for gcrypt-backend, Longpeng(Mike), 2017/04/22
- [Qemu-devel] [PATCH v3 04/18] crypto: cipher: introduce qcrypto_cipher_ctx_new for builtin-backend, Longpeng(Mike), 2017/04/22
- [Qemu-devel] [PATCH v3 03/18] crypto: cipher: introduce qcrypto_cipher_ctx_new for nettle-backend, Longpeng(Mike), 2017/04/22
- [Qemu-devel] [PATCH v3 09/18] crypto: hmac: introduce qcrypto_hmac_ctx_new for nettle-backend, Longpeng(Mike), 2017/04/22
- [Qemu-devel] [PATCH v3 05/18] crypto: cipher: add cipher driver framework, Longpeng(Mike), 2017/04/22