Re: [Qemu-devel] [PATCH v6 01/18] block: expose crypto option names / defs to other drivers

[Eric Blake]

On 04/25/2017 10:38 AM, Daniel P. Berrange wrote:
> The block/crypto.c defines a set of QemuOpts that provide
> parameters for encryption. This will also be needed by
> the qcow/qcow2 integration, so expose the relevant pieces
> in a new block/crypto.h header. Some helper methods taking
> QemuOpts are changed to take QDict to simplify usage in
> other places.
> 
> Reviewed-by: Max Reitz <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> Reviewed-by: Alberto Garcia <address@hidden>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
>  block/crypto.c | 82 +++++++++++++++++-----------------------------------
>  block/crypto.h | 91 
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 117 insertions(+), 56 deletions(-)
>  create mode 100644 block/crypto.h

> +++ b/block/crypto.h
> @@ -0,0 +1,91 @@
> +/*
> + * QEMU block full disk encryption
> + *
> + * Copyright (c) 2015-2016 Red Hat, Inc.

Wow, we've been working on this for a while. Is it worth adding 2017?

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature