[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] migration: Extra tracing
From: |
Christian Borntraeger |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] migration: Extra tracing |
Date: |
Wed, 26 Apr 2017 20:48:55 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 04/26/2017 08:37 PM, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <address@hidden>
>
> A couple more traces that would have made fixing that postcopy
> bug a bit easier.
>
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Acked-by: Christian Borntraeger <address@hidden>
> ---
> migration/ram.c | 2 ++
> migration/trace-events | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/migration/ram.c b/migration/ram.c
> index b4ed41c725..3ac41ccaba 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -812,6 +812,7 @@ static int ram_save_page(RAMState *rs, PageSearchStatus
> *pss, bool last_stage)
> ram_addr_t offset = pss->page << TARGET_PAGE_BITS;
>
> p = block->host + offset;
> + trace_ram_save_page(block->idstr, (uint64_t)offset, p);
>
> /* In doubt sent page as normal */
> bytes_xmit = 0;
> @@ -2614,6 +2615,7 @@ static int ram_load(QEMUFile *f, void *opaque, int
> version_id)
> ret = -EINVAL;
> break;
> }
> + trace_ram_load_loop(block->idstr, (uint64_t)addr, flags, host);
> }
>
> switch (flags & ~RAM_SAVE_FLAG_CONTINUE) {
> diff --git a/migration/trace-events b/migration/trace-events
> index b8f01a218c..5b8ccf301c 100644
> --- a/migration/trace-events
> +++ b/migration/trace-events
> @@ -69,8 +69,10 @@ migration_bitmap_sync_start(void) ""
> migration_bitmap_sync_end(uint64_t dirty_pages) "dirty_pages %" PRIu64
> migration_throttle(void) ""
> ram_discard_range(const char *rbname, uint64_t start, size_t len) "%s:
> start: %" PRIx64 " %zx"
> +ram_load_loop(const char *rbname, uint64_t addr, int flags, void *host) "%s:
> addr: %" PRIx64 " flags: %x host: %p"
> ram_load_postcopy_loop(uint64_t addr, int flags) "@%" PRIx64 " %x"
> ram_postcopy_send_discard_bitmap(void) ""
> +ram_save_page(const char *rbname, uint64_t offset, void *host) "%s: offset:
> %" PRIx64 " host: %p"
> ram_save_queue_pages(const char *rbname, size_t start, size_t len) "%s:
> start: %zx len: %zx"
>
> # migration/migration.c
>
- [Qemu-devel] [PATCH 0/2] Postcopy fix and traces, Dr. David Alan Gilbert (git), 2017/04/26
- [Qemu-devel] [PATCH 2/2] migration: Extra tracing, Dr. David Alan Gilbert (git), 2017/04/26
- Re: [Qemu-devel] [PATCH 2/2] migration: Extra tracing,
Christian Borntraeger <=
- [Qemu-devel] [PATCH 1/2] Postcopy: Force allocation of all-zero precopy pages, Dr. David Alan Gilbert (git), 2017/04/26
- Re: [Qemu-devel] [PATCH 1/2] Postcopy: Force allocation of all-zero precopy pages, Christian Borntraeger, 2017/04/26
- Re: [Qemu-devel] [PATCH 1/2] Postcopy: Force allocation of all-zero precopy pages, Dr. David Alan Gilbert, 2017/04/26
- Re: [Qemu-devel] [PATCH 1/2] Postcopy: Force allocation of all-zero precopy pages, Andrea Arcangeli, 2017/04/26
- Re: [Qemu-devel] [PATCH 1/2] Postcopy: Force allocation of all-zero precopy pages, Peter Xu, 2017/04/26
- Re: [Qemu-devel] [PATCH 1/2] Postcopy: Force allocation of all-zero precopy pages, Christian Borntraeger, 2017/04/27
- Re: [Qemu-devel] [PATCH 1/2] Postcopy: Force allocation of all-zero precopy pages, Andrea Arcangeli, 2017/04/27
- Re: [Qemu-devel] [PATCH 1/2] Postcopy: Force allocation of all-zero precopy pages, Christian Borntraeger, 2017/04/28
- Re: [Qemu-devel] [PATCH 1/2] Postcopy: Force allocation of all-zero precopy pages, Dr. David Alan Gilbert, 2017/04/28
- Re: [Qemu-devel] [PATCH 1/2] Postcopy: Force allocation of all-zero precopy pages, Christian Borntraeger, 2017/04/26