|
| From: | Wei Wang |
| Subject: | Re: [Qemu-devel] [virtio-dev] Re: [PATCH v9 2/5] virtio-balloon: VIRTIO_BALLOON_F_BALLOON_CHUNKS |
| Date: | Thu, 27 Apr 2017 14:31:49 +0800 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 04/27/2017 07:20 AM, Michael S. Tsirkin wrote:
On Wed, Apr 26, 2017 at 11:03:34AM +0000, Wang, Wei W wrote:Hi Michael, could you please give some feedback?I'm sorry, I'm not sure feedback on what you are requesting.
Oh, just some trivial things (e.g. use a field in the header, hdr->chunks to indicate the number of chunks in the payload) that wasn't confirmed. I will prepare the new version with fixing the agreed issues, and we can continue to discuss those parts if you still find them improper.
The interface looks reasonable now, even though there's a way to make it even simpler if we can limit chunk size to 2G (in fact 4G - 1). Do you think we can live with this limitation?
Yes, I think we can. So, is it good to change to use the previous 64-bit chunk format (52-bit base + 12-bit size)?
But the code still needs some cleanup.
OK. We'll also still to discuss your comments in the patch 05. Best, Wei
| [Prev in Thread] | Current Thread | [Next in Thread] |