[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv3 0/4] Clean up compatibility mode handling
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCHv3 0/4] Clean up compatibility mode handling |
Date: |
Thu, 27 Apr 2017 01:04:13 -0700 (PDT) |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: address@hidden
Subject: [Qemu-devel] [PATCHv3 0/4] Clean up compatibility mode handling
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
28f8147 ppc: Rework CPU compatibility testing across migration
07b83df pseries: Reset CPU compatibility mode
f9b3835 pseries: Move CPU compatibility property to machine
504c501 qapi: add explicit null to string input and output visitors
=== OUTPUT BEGIN ===
Checking PATCH 1/4: qapi: add explicit null to string input and output
visitors...
Checking PATCH 2/4: pseries: Move CPU compatibility property to machine...
ERROR: line over 90 characters
#372: FILE: target/ppc/translate_init.c:8430:
+ error_report("CPU 'compat' property is deprecated and has no effect; use
max-cpu-compat machine property instead");
total: 1 errors, 0 warnings, 332 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 3/4: pseries: Reset CPU compatibility mode...
Checking PATCH 4/4: ppc: Rework CPU compatibility testing across migration...
ERROR: braces {} are necessary for all arms of this statement
#96: FILE: target/ppc/machine.c:239:
+ if (cpu->compat_pvr) {
[...]
+ } else
[...]
total: 1 errors, 0 warnings, 102 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- [Qemu-devel] [PATCHv3 0/4] Clean up compatibility mode handling, David Gibson, 2017/04/27
- [Qemu-devel] [PATCHv3 1/4] qapi: add explicit null to string input and output visitors, David Gibson, 2017/04/27
- [Qemu-devel] [PATCHv3 4/4] ppc: Rework CPU compatibility testing across migration, David Gibson, 2017/04/27
- [Qemu-devel] [PATCHv3 2/4] pseries: Move CPU compatibility property to machine, David Gibson, 2017/04/27
- [Qemu-devel] [PATCHv3 3/4] pseries: Reset CPU compatibility mode, David Gibson, 2017/04/27
- Re: [Qemu-devel] [PATCHv3 0/4] Clean up compatibility mode handling,
no-reply <=
- Re: [Qemu-devel] [PATCHv3 0/4] Clean up compatibility mode handling, Greg Kurz, 2017/04/28