Re: [Qemu-devel] [PATCH v9] Allow setting NUMA distance for different NUMA nodes

[Markus Armbruster]

Igor Mammedov <address@hidden> writes:

> On Thu, 27 Apr 2017 07:54:31 -0500
> Eric Blake <address@hidden> wrote:
>
>> On 04/26/2017 09:35 PM, He Chen wrote:
>> > This patch is going to add SLIT table support in QEMU, and provides
>> > additional option `dist` for command `-numa` to allow user set vNUMA
>> > distance by QEMU command.
>> > 
>> > With this patch, when a user wants to create a guest that contains
>> > several vNUMA nodes and also wants to set distance among those nodes,
>> > the QEMU command would like:
>> > 
>> > ```
>> > -numa node,nodeid=0,cpus=0 \
>> > -numa node,nodeid=1,cpus=1 \
>> > -numa node,nodeid=2,cpus=2 \
>> > -numa node,nodeid=3,cpus=3 \
>> > -numa dist,src=0,dst=1,val=21 \
>> > -numa dist,src=0,dst=2,val=31 \
>> > -numa dist,src=0,dst=3,val=41 \
>> > -numa dist,src=1,dst=2,val=21 \
>> > -numa dist,src=1,dst=3,val=31 \
>> > -numa dist,src=2,dst=3,val=21 \
>> > ```
>> > 
>> > Signed-off-by: He Chen <address@hidden>
>> > 
>> > ---
>> > Changes since v8:
>> > * numa_{node, distance}_parse --> parse_numa_{node, distance}
>> > * Comments refinement.  
>> 
>> 
>> > ---
>> >  hw/acpi/aml-build.c         |  26 +++++++++
>> >  hw/i386/acpi-build.c        |   4 ++
>> >  include/hw/acpi/aml-build.h |   1 +
>> >  include/sysemu/numa.h       |   2 +
>> >  include/sysemu/sysemu.h     |   4 ++
>> >  numa.c                      | 137 
>> > +++++++++++++++++++++++++++++++++++++++++++-
>> >  qapi-schema.json            |  30 +++++++++-
>> >  qemu-options.hx             |  16 +++++-
>> >  8 files changed, 215 insertions(+), 5 deletions(-)  
>> 
>> Markus has asked that all new QMP commands have some testsuite exposure;
>> he may have some advice on what test would be best to modify to give us
>> some coverage of this feature.

I can't see the QMP command here, but...

> Since it's basically validation of SLIT table, the test case
> should be added to tests/bios-tables-test.c

... I figure there's new stuff to test all the same.