[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] checkpatch: Disallow glib asserts in main code
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH] checkpatch: Disallow glib asserts in main code |
|
Date: |
Fri, 28 Apr 2017 14:46:37 +0100 |
On 28 April 2017 at 14:34, Markus Armbruster <address@hidden> wrote:
> If these are screwy enough to warrant rejecting them in new code,
> they're probably screwy enough to purge them from existing code:
>
> include/glib-compat.h:#ifndef g_assert_true
> include/glib-compat.h:#define g_assert_true(expr)
These ones prompted me to wonder if we could/should use
#pragma GCC poison g_assert_true
rather than just leaving it up to checkpatch.
thanks
-- PMM