Re: [Qemu-devel] [PATCH v5 + 1/2] target/aarch64: optimize cross-page direct jumps in softmmu

[Richard Henderson]

On 04/28/2017 09:22 PM, Emilio G. Cota wrote:
> On Fri, Apr 28, 2017 at 15:17:24 -0400, Emilio G. Cota wrote:
> > Perf numbers in next commit's log.
> >
> > Signed-off-by: Emilio G. Cota <address@hidden>
> > ---
> >   target/arm/translate-a64.c | 3 +--
> >   1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
> > index 24de30d..5b691fc 100644
> > --- a/target/arm/translate-a64.c
> > +++ b/target/arm/translate-a64.c
> > @@ -373,8 +373,7 @@ static inline void gen_goto_tb(DisasContext *s, int n, 
> > uint64_t dest)
> >           } else if (s->singlestep_enabled) {
> >               gen_exception_internal(EXCP_DEBUG);
> >           } else {
> > -            tcg_gen_exit_tb(0);
> > -            s->is_jmp = DISAS_TB_JUMP;
>
> I'm not sure about removing this line though. Would it be better to leave it?
> I can't see how TB_JUMP ends up doing anything in the rest of the file.

Why not just replace this with

  s->is_jmp = DISAS_JUMP

and not emit the lookup_and_goto_ptr here at all?


r~