[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] (RFC) remove the GThread coroutine implementati
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH] (RFC) remove the GThread coroutine implementation |
Date: |
Sun, 30 Apr 2017 07:20:54 +0100 |
User-agent: |
mu4e 0.9.19; emacs 25.2.17 |
Richard Henderson <address@hidden> writes:
> On 04/28/2017 02:24 PM, Daniel P. Berrange wrote:
>> At the 2016 summit it was suggested that we delete the GThread
>> coroutine impl since it is not fully functional, and you can
>> debug the ucontext impl with our GDB helper script.
>>
>> I don't recall the subject being raised again since the summit
>> so here's a proposal to delete the GThread impl, as a way to
>> trigger input from anyone who thinks we need to keep it......
>
> The last time this was mentioned, the reason that we were keeping it
> was to make clang's thread-sanitizer module happy. Whether we can
> still find relevant bugs with that, I don't know.
It's been a while since I last did a ThreadSanitizer run. The correct
fix is teaching the sanitizer about set context so we can use our normal
build - however this has been at the bottom of a pile for such a long
time.
--
Alex Bennée