Re: [Qemu-devel] [PATCH v2 5/9] tmp backend: Add new api to read backend TpmInfo

[Amarnath Valluri]

On 04/25/2017 09:59 PM, Eric Blake wrote:
> On 04/25/2017 01:51 PM, Stefan Berger wrote:
>
> > > +++ b/qapi-schema.json
> > > @@ -5140,6 +5140,16 @@
> > >    { 'command': 'query-tpm-types', 'returns': ['TpmType'] }
> > >
> > >    ##
> > > +# @TPMOptions:
> > > +#
> > > +# Base type for TPM options
> > > +#
> > > +# Since: 2.10
> > > +##
> > > +{ 'struct': 'TPMOptions',
> > > +  'data': { } }
> > > +
> > > +##
> > >    # @TPMPassthroughOptions:
> > >    #
> > >    # Information about the TPM passthrough type
> > > @@ -5151,20 +5161,9 @@
> > >    #
> > >    # Since: 1.5
> > >    ##
> > > -{ 'struct': 'TPMPassthroughOptions', 'data': { '*path' : 'str',
> > > -                                             '*cancel-path' : 'str'} }
> > > +{ 'struct': 'TPMPassthroughOptions', 'base': 'TPMOptions',
> > > +  'data': { '*path' : 'str', '*cancel-path' : 'str'} }
> >
> > I don't think that you can change it like this anymore since this is
> > part of the public interface.
> The change is backwards compatible; it doesn't break any existing QMP
> usage.  It's weird to have an empty base class, though.
This empty base class(TPMOptions) makes sense when its shared by more 
than one(Passthrough and Emulator) bakcends.

- Amarnath