[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v16 15/22] file-posix: Add 'locking' option
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v16 15/22] file-posix: Add 'locking' option |
Date: |
Tue, 2 May 2017 23:49:20 +0800 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Tue, 05/02 16:15, Kevin Wolf wrote:
> > diff --git a/qapi/block-core.json b/qapi/block-core.json
> > index 1cf29a1..29d3040 100644
> > --- a/qapi/block-core.json
> > +++ b/qapi/block-core.json
> > @@ -2127,11 +2127,15 @@
> > #
> > # @filename: path to the image file
> > # @aio: AIO backend (default: threads) (since: 2.8)
> > +# @locking: whether to enable file locking. If set to 'auto', only
> > enable
> > +# when Open File Descriptor (OFD) locking API is available
> > +# (default: auto, since 2.10)
> > #
> > # Since: 2.9
> > ##
> > { 'struct': 'BlockdevOptionsFile',
> > 'data': { 'filename': 'str',
> > + '*locking': 'OnOffAuto',
> > '*aio': 'BlockdevAioOptions' } }
>
> It's unfortunate that file-posix and file-win32 share the same QAPI
> type. Should we add a file-win32 implementation that just errors out
> when locking=on is specified, or is it enough that block.c notices that
> there is an option that hasn't been processed? (Even locking=off would
> cause failure then.)
That will make it a bit more like an oversight, maybe only error out when
locking=on is better.
Fam
- [Qemu-devel] [PATCH v16 06/22] qemu-io: Add --force-share option, (continued)
- [Qemu-devel] [PATCH v16 06/22] qemu-io: Add --force-share option, Fam Zheng, 2017/05/02
- [Qemu-devel] [PATCH v16 07/22] iotests: 030: Prepare for image locking, Fam Zheng, 2017/05/02
- [Qemu-devel] [PATCH v16 08/22] iotests: 046: Prepare for image locking, Fam Zheng, 2017/05/02
- [Qemu-devel] [PATCH v16 09/22] iotests: 055: Don't attach the target image already for drive-backup, Fam Zheng, 2017/05/02
- [Qemu-devel] [PATCH v16 10/22] iotests: 085: Avoid image locking conflict, Fam Zheng, 2017/05/02
- [Qemu-devel] [PATCH v16 11/22] iotests: 087: Don't attach test image twice, Fam Zheng, 2017/05/02
- [Qemu-devel] [PATCH v16 12/22] iotests: 091: Quit QEMU before checking image, Fam Zheng, 2017/05/02
- [Qemu-devel] [PATCH v16 13/22] iotests: 172: Use separate images for multiple devices, Fam Zheng, 2017/05/02
- [Qemu-devel] [PATCH v16 15/22] file-posix: Add 'locking' option, Fam Zheng, 2017/05/02
- [Qemu-devel] [PATCH v16 14/22] tests: Use null-co:// instead of /dev/null as the dummy image, Fam Zheng, 2017/05/02
- [Qemu-devel] [PATCH v16 16/22] tests: Disable image lock in test-replication, Fam Zheng, 2017/05/02
- [Qemu-devel] [PATCH v16 17/22] block: Reuse bs as backing hd for drive-backup sync=none, Fam Zheng, 2017/05/02
- [Qemu-devel] [PATCH v16 18/22] osdep: Add qemu_lock_fd and qemu_unlock_fd, Fam Zheng, 2017/05/02
- [Qemu-devel] [PATCH v16 19/22] osdep: Fall back to posix lock when OFD lock is unavailable, Fam Zheng, 2017/05/02
- [Qemu-devel] [PATCH v16 20/22] file-posix: Add image locking to perm operations, Fam Zheng, 2017/05/02
- [Qemu-devel] [PATCH v16 22/22] tests: Add POSIX image locking test case 182, Fam Zheng, 2017/05/02
- [Qemu-devel] [PATCH v16 21/22] qemu-iotests: Add test case 153 for image locking, Fam Zheng, 2017/05/02