[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v17 18/23] block: Reuse bs as backing hd for dri
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v17 18/23] block: Reuse bs as backing hd for drive-backup sync=none |
Date: |
Wed, 3 May 2017 00:44:35 +0800 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Wed, 05/03 00:35, Fam Zheng wrote:
> Opening the backing image for the second time is bad, especially here
> when it is also in use as the active image as the source. The
> drive-backup job itself doesn't read from target->backing for COW,
> instead it gets data from the write notifier, so it's not a big problem.
> However, exporting the target to NBD etc. won't work, because of the
> likely stale metadata cache.
>
> Use BDRV_O_NO_BACKING in this case and manually set up the backing
> BdrvChild.
>
> Cc: address@hidden
> Signed-off-by: Fam Zheng <address@hidden>
Actually Cc qemu-stable. (git-publish does unified Cc for each patch in a whole
series, hence the noise. Sorry.)
Fam
- [Qemu-devel] [PATCH v17 09/23] iotests: 055: Don't attach the target image already for drive-backup, (continued)
- [Qemu-devel] [PATCH v17 09/23] iotests: 055: Don't attach the target image already for drive-backup, Fam Zheng, 2017/05/02
- [Qemu-devel] [PATCH v17 11/23] iotests: 087: Don't attach test image twice, Fam Zheng, 2017/05/02
- [Qemu-devel] [PATCH v17 10/23] iotests: 085: Avoid image locking conflict, Fam Zheng, 2017/05/02
- [Qemu-devel] [PATCH v17 12/23] iotests: 091: Quit QEMU before checking image, Fam Zheng, 2017/05/02
- [Qemu-devel] [PATCH v17 13/23] iotests: 172: Use separate images for multiple devices, Fam Zheng, 2017/05/02
- [Qemu-devel] [PATCH v17 14/23] tests: Use null-co:// instead of /dev/null as the dummy image, Fam Zheng, 2017/05/02
- [Qemu-devel] [PATCH v17 15/23] file-posix: Add 'locking' option, Fam Zheng, 2017/05/02
- [Qemu-devel] [PATCH v17 16/23] file-win32: Error out if locking=on, Fam Zheng, 2017/05/02
- [Qemu-devel] [PATCH v17 17/23] tests: Disable image lock in test-replication, Fam Zheng, 2017/05/02
- [Qemu-devel] [PATCH v17 18/23] block: Reuse bs as backing hd for drive-backup sync=none, Fam Zheng, 2017/05/02
- Re: [Qemu-devel] [PATCH v17 18/23] block: Reuse bs as backing hd for drive-backup sync=none,
Fam Zheng <=
- [Qemu-devel] [PATCH v17 19/23] osdep: Add qemu_lock_fd and qemu_unlock_fd, Fam Zheng, 2017/05/02
- [Qemu-devel] [PATCH v17 20/23] osdep: Fall back to posix lock when OFD lock is unavailable, Fam Zheng, 2017/05/02
- [Qemu-devel] [PATCH v17 21/23] file-posix: Add image locking to perm operations, Fam Zheng, 2017/05/02
- [Qemu-devel] [PATCH v17 23/23] tests: Add POSIX image locking test case 182, Fam Zheng, 2017/05/02
- [Qemu-devel] [PATCH v17 22/23] qemu-iotests: Add test case 153 for image locking, Fam Zheng, 2017/05/02
- Re: [Qemu-devel] [PATCH v17 00/23] block: Image locking series, Kevin Wolf, 2017/05/04