[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 02/10] migration: setup bi-directional I/O channel fo
From: |
Juan Quintela |
Subject: |
[Qemu-devel] [PULL 02/10] migration: setup bi-directional I/O channel for exec: protocol |
Date: |
Thu, 4 May 2017 11:40:45 +0200 |
From: "Daniel P. Berrange" <address@hidden>
Historically the migration data channel has only needed to be
unidirectional. Thus the 'exec:' protocol was requesting an
I/O channel with O_RDONLY on incoming side, and O_WRONLY on
the outgoing side.
This is fine for classic migration, but if you then try to run
TLS over it, this fails because the TLS handshake requires a
bi-directional channel.
Signed-off-by: Daniel P. Berrange <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>
---
migration/exec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/migration/exec.c b/migration/exec.c
index 9157721..aba9089 100644
--- a/migration/exec.c
+++ b/migration/exec.c
@@ -32,7 +32,7 @@ void exec_start_outgoing_migration(MigrationState *s, const
char *command, Error
trace_migration_exec_outgoing(command);
ioc = QIO_CHANNEL(qio_channel_command_new_spawn(argv,
- O_WRONLY,
+ O_RDWR,
errp));
if (!ioc) {
return;
@@ -59,7 +59,7 @@ void exec_start_incoming_migration(const char *command, Error
**errp)
trace_migration_exec_incoming(command);
ioc = QIO_CHANNEL(qio_channel_command_new_spawn(argv,
- O_RDONLY,
+ O_RDWR,
errp));
if (!ioc) {
return;
--
2.9.3
- [Qemu-devel] [PULL 00/10] Migration PULL requset, Juan Quintela, 2017/05/04
- [Qemu-devel] [PULL 02/10] migration: setup bi-directional I/O channel for exec: protocol,
Juan Quintela <=
- [Qemu-devel] [PULL 03/10] migration: to_dst_file at that point is NULL, Juan Quintela, 2017/05/04
- [Qemu-devel] [PULL 01/10] ram: Split dirty bitmap by RAMBlock, Juan Quintela, 2017/05/04
- [Qemu-devel] [PULL 04/10] monitor: Remove monitor parameter from save_vmstate, Juan Quintela, 2017/05/04
- [Qemu-devel] [PULL 05/10] monitor: Move hmp_loadvm from monitor.c to hmp.c, Juan Quintela, 2017/05/04
- [Qemu-devel] [PULL 07/10] monitor: Move hmp_delvm from savevm.c to hmp.c, Juan Quintela, 2017/05/04
- [Qemu-devel] [PULL 06/10] monitor: Move hmp_savevm from savevm.c to hmp.c, Juan Quintela, 2017/05/04
- [Qemu-devel] [PULL 08/10] monitor: Move hmp_info_snapshots from savevm.c to hmp.c, Juan Quintela, 2017/05/04
- [Qemu-devel] [PULL 10/10] migration: Extra tracing, Juan Quintela, 2017/05/04
- [Qemu-devel] [PULL 09/10] migration: Move postcopy-ram.h to migration/, Juan Quintela, 2017/05/04
- Re: [Qemu-devel] [PULL 00/10] Migration PULL requset, Stefan Hajnoczi, 2017/05/05