[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/4] qmp-shell: improve help
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 4/4] qmp-shell: improve help |
Date: |
Thu, 04 May 2017 16:48:07 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Marc-André Lureau <address@hidden> writes:
> Describe the arguments & fix the tool name.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> scripts/qmp/qmp-shell | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/qmp/qmp-shell b/scripts/qmp/qmp-shell
> index db24c87cdd..fce1ab6c49 100755
> --- a/scripts/qmp/qmp-shell
> +++ b/scripts/qmp/qmp-shell
> @@ -375,7 +375,11 @@ def die(msg):
> def fail_cmdline(option=None):
> if option:
> sys.stderr.write('ERROR: bad command-line option \'%s\'\n' % option)
> - sys.stderr.write('qemu-shell [ -v ] [ -p ] [ -H ] [ -N ] < UNIX socket
> path> | < TCP address:port >\n')
> + sys.stderr.write('qmp-shell [ -v ] [ -p ] [ -H ] [ -N ] < UNIX socket
> path> | < TCP address:port >\n')
> + sys.stderr.write(' -v Verbose (echo command sent and received)\n')
> + sys.stderr.write(' -p Pretty-print JSON\n')
> + sys.stderr.write(' -H Use HMP interface\n')
> + sys.stderr.write(' -N Skip negotiate (for qemu-ga)\n')
> sys.exit(1)
>
> def main():
Given Python modules like argparse, doing option parsing by hand is
basically stupid. I'll take this patch anyway, because it improves help
without making the program appreciably stupider.
- [Qemu-devel] [PATCH 1/4] qmp-shell: add -N option to skip negotiate, (continued)
- [Qemu-devel] [PATCH 1/4] qmp-shell: add -N option to skip negotiate, Marc-André Lureau, 2017/05/04
- [Qemu-devel] [PATCH 2/4] qmp-shell: ignore query-commands error, Marc-André Lureau, 2017/05/04
- [Qemu-devel] [PATCH 3/4] qmp-shell: don't show version greeting if unavailable, Marc-André Lureau, 2017/05/04
- [Qemu-devel] [PATCH 4/4] qmp-shell: improve help, Marc-André Lureau, 2017/05/04
- Re: [Qemu-devel] [PATCH 0/4] qmp-shell: learn to connect to qemu-ga, Markus Armbruster, 2017/05/04