[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/6] block: Inactivate parents before children
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 4/6] block: Inactivate parents before children |
Date: |
Thu, 4 May 2017 12:23:54 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 |
On 05/04/2017 11:52 AM, Kevin Wolf wrote:
> The proper order for inactivating block nodes is that first the parents
> get inactivated and then the children. If we do things in this order, we
> can assert that we didn't accidentally leave a parent activated when one
> of its child nodes is inactive.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block.c | 25 ++++++++++++++++++-------
> 1 file changed, 18 insertions(+), 7 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/6] block: Fix op blockers for inactive images, Kevin Wolf, 2017/05/04
- [Qemu-devel] [PATCH 1/6] migration: Unify block node activation error handling, Kevin Wolf, 2017/05/04
- [Qemu-devel] [PATCH 2/6] block: New BdrvChildRole.activate() for blk_resume_after_migration(), Kevin Wolf, 2017/05/04
- [Qemu-devel] [PATCH 3/6] block: Drop permissions when migration completes, Kevin Wolf, 2017/05/04
- [Qemu-devel] [PATCH 4/6] block: Inactivate parents before children, Kevin Wolf, 2017/05/04
- Re: [Qemu-devel] [PATCH 4/6] block: Inactivate parents before children,
Eric Blake <=
- [Qemu-devel] [PATCH 5/6] block: Fix write/resize permissions for inactive images, Kevin Wolf, 2017/05/04
- [Qemu-devel] [PATCH 6/6] file-posix: Remove .bdrv_inactivate/invalidate_cache, Kevin Wolf, 2017/05/04
- Re: [Qemu-devel] [PATCH 0/6] block: Fix op blockers for inactive images, Kevin Wolf, 2017/05/09