[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/1] slirp: don't zero ti_i since we acccess it
From: |
Samuel Thibault |
Subject: |
Re: [Qemu-devel] [PATCH 1/1] slirp: don't zero ti_i since we acccess it later. |
Date: |
Fri, 5 May 2017 01:05:20 +0200 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
Hello,
lepton, on mer. 03 mai 2017 11:35:05 -0700, wrote:
> It sounds like a bug that caller set up a
> right src and dst address and without set right ih_x1.
I wouldn't bet on that. ih_x1 is only a filler, the caller can be using
the structure only as a C structure, and it's only here just before the
checksum computation that we really need ih_x1 to be 0.
Samuel