[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v1 2/5] pc-bios/s390-ccw: Remove duplicate b
From: |
Christian Borntraeger |
Subject: |
Re: [Qemu-devel] [RFC PATCH v1 2/5] pc-bios/s390-ccw: Remove duplicate blk_factor adjustment |
Date: |
Fri, 5 May 2017 09:10:25 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 04/26/2017 04:46 PM, Eric Farman wrote:
> When using virtio-scsi, we multiply the READ(10) data_size by
> a block factor twice when building the I/O. This is fine,
> since it's only 1 for SCSI disks, but let's clean it up.
>
> Signed-off-by: Eric Farman <address@hidden>
Reviewed-by: Christian Borntraeger <address@hidden>
> ---
> pc-bios/s390-ccw/virtio-scsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/pc-bios/s390-ccw/virtio-scsi.c b/pc-bios/s390-ccw/virtio-scsi.c
> index d850a8d..69b7a93 100644
> --- a/pc-bios/s390-ccw/virtio-scsi.c
> +++ b/pc-bios/s390-ccw/virtio-scsi.c
> @@ -154,7 +154,7 @@ static bool scsi_read_10(VDev *vdev,
> VirtioCmd read_10[] = {
> { &req, sizeof(req), VRING_DESC_F_NEXT },
> { &resp, sizeof(resp), VRING_DESC_F_WRITE | VRING_DESC_F_NEXT },
> - { data, data_size * f, VRING_DESC_F_WRITE },
> + { data, data_size, VRING_DESC_F_WRITE },
> };
>
> debug_print_int("read_10 sector", sector);
>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [RFC PATCH v1 2/5] pc-bios/s390-ccw: Remove duplicate blk_factor adjustment,
Christian Borntraeger <=