Re: [Qemu-devel] [PATCH 1/5] docker: Run tests with current user

[Alex Bennée]

Fam Zheng <address@hidden> writes:

> We've used --add-current-user to create a user in the image, use it to
> run tests, because root has too much priviledge, and can surprise test
> cases.
>
> Signed-off-by: Fam Zheng <address@hidden>

Reviewed-by: Alex Bennée <address@hidden>

> ---
>  tests/docker/Makefile.include | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
> index 03eda37..0ed8c3d 100644
> --- a/tests/docker/Makefile.include
> +++ b/tests/docker/Makefile.include
> @@ -126,7 +126,7 @@ docker-run: docker-qemu-src
>                       "  COPYING $(EXECUTABLE) to $(IMAGE)"))
>       $(call quiet-command,                                           \
>               $(SRC_PATH)/tests/docker/docker.py run                  \
> -                     -t                                              \
> +                     $(if $(NOUSER),,-u $(shell id -u)) -t           \
>                       $(if $V,,--rm)                                  \
>                       $(if $(DEBUG),-i,--net=none)                    \
>                       -e TARGET_LIST=$(TARGET_LIST)                   \


--
Alex Bennée