[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v1 0/5] Enable virtio-scsi boot from /dev/sg
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [RFC PATCH v1 0/5] Enable virtio-scsi boot from /dev/sgX |
Date: |
Fri, 5 May 2017 17:13:41 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 |
On 05/05/2017 17:03, Eric Farman wrote:
> We get a value of x3fffff when sending that to a scsi-disk from bios
> code. That's fully emulated though, in scsi_disk_emulate_inquiry. And
> that's the scenario that already works.
>
> While there is indeed code in hw/scsi/scsi-generic.c to wire that in,
> that only happens after the I/O goes to the device itself. The Block
> Limits page isn't supported [1] and thus it gets rejected with "invalid
> field in cdb". We never get to that fixup code you reference, since the
> returned len is zero.
>
> Should I be refactoring this code to always patch in that block limit
> regardless of a response from the host/device? (That is, when page xb0
> isn't supported by the hw.)
What is the BLKSECTGET value you get? Is there a sensible default value
that you can use when page 0xb0 isn't supported by the hardware?
Thanks,
Paolo