Re: [Qemu-devel] [PULL 00/23] Trivial patches for 2017-05-07

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PULL 00/23] Trivial patches for 2017-05-07
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
8acf5d3 tests: Remove redundant assignment
0f494a6 MAINTAINERS: Update paths for AioContext implementation
9974be0 MAINTAINERS: Update paths for main loop
3e8c3af jazz_led: fix bad snprintf
8f753b9 tests: Ignore another built executable (test-hmp)
7d5489d scripts: Switch to more portable Perl shebang
536d031 scripts/qemu-binfmt-conf.sh: Fix shell portability issue
a3e0b2b virtfs: allow a device id to be specified in the -virtfs option
3227c55 hw/core/generic-loader: Fix crash when running without CPU
22bf6ca virtio-blk: Remove useless condition around g_free()
65fe06c qemu-doc: Fix broken URLs of amnhltm.zip and dosidle210.zip
1f55ac0 use _Static_assert in QEMU_BUILD_BUG_ON
58005fb channel-file: fix wrong parameter comments
9029b8b block: Make 'replication_state' an enum
d5f07f0 util: Use g_malloc/g_free in envlist.c
e1d8273 qga: fix compiler warnings (clang 5)
077a79e device_tree: fix compiler warnings (clang 5)
965b305 usb-ccid: make ccid_write_data_block() cope with null buffers
3b19d93 tests: Ignore more test executables
296cc0d Add 'none' as type for drive's if option
708674a doc: fix function spelling
afcc583 ppc_booke: drop useless assignment
8b94589 Remove reduntant qemu: from error functions

=== OUTPUT BEGIN ===
Checking PATCH 1/23: Remove reduntant qemu: from error functions...
Checking PATCH 2/23: ppc_booke: drop useless assignment...
Checking PATCH 3/23: doc: fix function spelling...
Checking PATCH 4/23: Add 'none' as type for drive's if option...
Checking PATCH 5/23: tests: Ignore more test executables...
Checking PATCH 6/23: usb-ccid: make ccid_write_data_block() cope with null 
buffers...
Checking PATCH 7/23: device_tree: fix compiler warnings (clang 5)...
Checking PATCH 8/23: qga: fix compiler warnings (clang 5)...
Checking PATCH 9/23: util: Use g_malloc/g_free in envlist.c...
ERROR: code indent should never use tabs
#116: FILE: util/envlist.c:27:
+^Ienvlist = g_malloc(sizeof(*envlist));$

ERROR: code indent should never use tabs
#126: FILE: util/envlist.c:49:
+^I^Ig_free((char *)entry->ev_var);$

ERROR: code indent should never use tabs
#127: FILE: util/envlist.c:50:
+^I^Ig_free(entry);$

ERROR: code indent should never use tabs
#130: FILE: util/envlist.c:52:
+^Ig_free(envlist);$

ERROR: code indent should never use tabs
#140: FILE: util/envlist.c:102:
+^Itmpenv = g_strdup(env);$

ERROR: code indent should never use tabs
#159: FILE: util/envlist.c:155:
+^I^Ig_free((char *)entry->ev_var);$

ERROR: code indent should never use tabs
#160: FILE: util/envlist.c:156:
+^I^Ig_free(entry);$

ERROR: code indent should never use tabs
#171: FILE: util/envlist.c:161:
+^Ientry = g_malloc(sizeof(*entry));$

ERROR: code indent should never use tabs
#172: FILE: util/envlist.c:162:
+^Ientry->ev_var = g_strdup(env);$

ERROR: code indent should never use tabs
#182: FILE: util/envlist.c:197:
+^I^Ig_free((char *)entry->ev_var);$

ERROR: code indent should never use tabs
#183: FILE: util/envlist.c:198:
+^I^Ig_free(entry);$

ERROR: code indent should never use tabs
#211: FILE: util/envlist.c:221:
+^Ipenv = env = g_malloc((envlist->el_count + 1) * sizeof(char *));$

ERROR: code indent should never use tabs
#216: FILE: util/envlist.c:225:
+^I^I*(penv++) = g_strdup(entry->ev_var);$

total: 13 errors, 0 warnings, 168 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 10/23: block: Make 'replication_state' an enum...
Checking PATCH 11/23: channel-file: fix wrong parameter comments...
Checking PATCH 12/23: use _Static_assert in QEMU_BUILD_BUG_ON...
Checking PATCH 13/23: qemu-doc: Fix broken URLs of amnhltm.zip and 
dosidle210.zip...
Checking PATCH 14/23: virtio-blk: Remove useless condition around g_free()...
Checking PATCH 15/23: hw/core/generic-loader: Fix crash when running without 
CPU...
Checking PATCH 16/23: virtfs: allow a device id to be specified in the -virtfs 
option...
Checking PATCH 17/23: scripts/qemu-binfmt-conf.sh: Fix shell portability 
issue...
Checking PATCH 18/23: scripts: Switch to more portable Perl shebang...
Checking PATCH 19/23: tests: Ignore another built executable (test-hmp)...
Checking PATCH 20/23: jazz_led: fix bad snprintf...
Checking PATCH 21/23: MAINTAINERS: Update paths for main loop...
Checking PATCH 22/23: MAINTAINERS: Update paths for AioContext implementation...
Checking PATCH 23/23: tests: Remove redundant assignment...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden