qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] xtensa: use g_malloc/g_new/g_free


From: Philippe Mathieu-Daudé
Subject: Re: [Qemu-devel] [PATCH] xtensa: use g_malloc/g_new/g_free
Date: Mon, 8 May 2017 08:46:34 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0

On 05/08/2017 04:35 AM, Paolo Bonzini wrote:
Replace malloc/free with g_malloc/g_free to get a program exit on
out of memory.

Replace g_malloc with g_new when allocating the MemoryRegion to
get more type safety.

Reported by Coverity.

Cc: Max Filippov <address@hidden>
Cc: address@hidden
Signed-off-by: Paolo Bonzini <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

---
 hw/xtensa/sim.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/hw/xtensa/sim.c b/hw/xtensa/sim.c
index d2d1d3a6fd..97307728f7 100644
--- a/hw/xtensa/sim.c
+++ b/hw/xtensa/sim.c
@@ -41,13 +41,13 @@ static void xtensa_create_memory_regions(const XtensaMemory 
*memory,
                                          const char *name)
 {
     unsigned i;
-    char *num_name = malloc(strlen(name) + sizeof(i) * 3 + 1);
+    char *num_name = g_malloc(strlen(name) + sizeof(i) * 3 + 1);

     for (i = 0; i < memory->num; ++i) {
         MemoryRegion *m;

         sprintf(num_name, "%s%u", name, i);
-        m = g_malloc(sizeof(*m));
+        m = g_new(MemoryRegion, 1);
         memory_region_init_ram(m, NULL, num_name,
                                memory->location[i].size,
                                &error_fatal);
@@ -55,7 +55,7 @@ static void xtensa_create_memory_regions(const XtensaMemory 
*memory,
         memory_region_add_subregion(get_system_memory(),
                                     memory->location[i].addr, m);
     }
-    free(num_name);
+    g_free(num_name);
 }

 static uint64_t translate_phys_addr(void *opaque, uint64_t addr)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]