[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 1/9] block: add bdrv_measure() API
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v6 1/9] block: add bdrv_measure() API |
Date: |
Mon, 8 May 2017 09:50:06 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 05/08/2017 09:15 AM, Stefan Hajnoczi wrote:
> bdrv_measure() provides a conservative maximum for the size of a new
> image. This information is handy if storage needs to be allocated (e.g.
> a SAN or an LVM volume) ahead of time.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> Reviewed-by: Alberto Garcia <address@hidden>
It looks like non-trivial changes since v5, are you sure this R-b is
still appropriate?
> ---
> v6:
> * Change bdrv_measure() return type to BlockMeasureInfo * [Eric]
> * Clarify that holes in sparse POSIX files are still counted [Eric]
> ---
> qapi/block-core.json | 25 +++++++++++++++++++++++++
> include/block/block.h | 2 ++
> include/block/block_int.h | 2 ++
> block.c | 35 +++++++++++++++++++++++++++++++++++
> 4 files changed, 64 insertions(+)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v6 0/9] qemu-img: add measure sub-command, Stefan Hajnoczi, 2017/05/08
- [Qemu-devel] [PATCH v6 1/9] block: add bdrv_measure() API, Stefan Hajnoczi, 2017/05/08
- Re: [Qemu-devel] [PATCH v6 1/9] block: add bdrv_measure() API,
Eric Blake <=
- [Qemu-devel] [PATCH v6 2/9] raw-format: add bdrv_measure() support, Stefan Hajnoczi, 2017/05/08
- [Qemu-devel] [PATCH v6 3/9] qcow2: extract preallocation calculation function, Stefan Hajnoczi, 2017/05/08
- [Qemu-devel] [PATCH v6 4/9] qcow2: make refcount size calculation conservative, Stefan Hajnoczi, 2017/05/08
- [Qemu-devel] [PATCH v6 5/9] qcow2: extract image creation option parsing, Stefan Hajnoczi, 2017/05/08