[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v13 01/12] qcow2: Nicer variable names in qcow2_
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v13 01/12] qcow2: Nicer variable names in qcow2_update_snapshot_refcount() |
Date: |
Mon, 8 May 2017 17:27:32 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 |
On 07.05.2017 02:05, Eric Blake wrote:
> In order to keep checkpatch happy when the next patch changes
> indentation, we first have to shorten some long lines. The easiest
> approach is to use a new variable in place of
> 'offset & L2E_OFFSET_MASK', except that 'offset' is the best name
> for that variable. Change '[old_]offset' to '[old_]entry' to
> make room.
>
> While touching things, also fix checkpatch warnings about unusual
> 'for' statements.
>
> Suggested by Max Reitz <address@hidden>
> Signed-off-by: Eric Blake <address@hidden>
>
> ---
> v13: new patch
> ---
> block/qcow2-refcount.c | 42 ++++++++++++++++++++++--------------------
> 1 file changed, 22 insertions(+), 20 deletions(-)
>
> diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
> index 4efca7e..db0af2c 100644
> --- a/block/qcow2-refcount.c
> +++ b/block/qcow2-refcount.c
[...]
> @@ -1117,20 +1118,22 @@ int qcow2_update_snapshot_refcount(BlockDriverState
> *bs,
> goto fail;
> }
>
> - for(j = 0; j < s->l2_size; j++) {
> + for (j = 0; j < s->l2_size; j++) {
> uint64_t cluster_index;
> + uint64_t offset;
Actually, introducing entry and old_entry in this scope would have
sufficed, too, because they aren't used anywhere else. But nobody
actually cares (O:-)), so:
Reviewed-by: Max Reitz <address@hidden>
>
> - offset = be64_to_cpu(l2_table[j]);
> - old_offset = offset;
> - offset &= ~QCOW_OFLAG_COPIED;
> + entry = be64_to_cpu(l2_table[j]);
> + old_entry = entry;
> + entry &= ~QCOW_OFLAG_COPIED;
> + offset = entry & L2E_OFFSET_MASK;
>
> - switch (qcow2_get_cluster_type(offset)) {
> + switch (qcow2_get_cluster_type(entry)) {
> case QCOW2_CLUSTER_COMPRESSED:
> - nb_csectors = ((offset >> s->csize_shift) &
> + nb_csectors = ((entry >> s->csize_shift) &
> s->csize_mask) + 1;
> if (addend != 0) {
> ret = update_refcount(bs,
> - (offset & s->cluster_offset_mask) & ~511,
> + (entry & s->cluster_offset_mask) & ~511,
> nb_csectors * 512, abs(addend), addend < 0,
> QCOW2_DISCARD_SNAPSHOT);
> if (ret < 0) {
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v13 00/12] qcow2 zero-cluster tweaks [was add blkdebug tests], Eric Blake, 2017/05/06
- [Qemu-devel] [PATCH v13 03/12] block: Update comments on BDRV_BLOCK_* meanings, Eric Blake, 2017/05/06
- [Qemu-devel] [PATCH v13 02/12] qcow2: Use consistent switch indentation, Eric Blake, 2017/05/06
- [Qemu-devel] [PATCH v13 04/12] qcow2: Correctly report status of preallocated zero clusters, Eric Blake, 2017/05/06
- [Qemu-devel] [PATCH v13 05/12] qcow2: Name typedef for cluster type, Eric Blake, 2017/05/06
- [Qemu-devel] [PATCH v13 07/12] qcow2: Optimize zero_single_l2() to minimize L2 churn, Eric Blake, 2017/05/06