[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v3 05/28] coccinelle: Add script to remove useless QO
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PULL v3 05/28] coccinelle: Add script to remove useless QObject casts |
Date: |
Tue, 9 May 2017 10:06:22 +0200 |
From: Eric Blake <address@hidden>
We have macros in place to make it less verbose to add a subtype
of QObject to both QDict and QList. While we have made cleanups
like this in the past (see commit fcfcd8ffc, for example), having
it be automated by Coccinelle makes it easier to maintain.
The script is separate from the cleanups, for ease of review and
backporting. A later patch will then add further possible cleanups.
Signed-off-by: Eric Blake <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
---
MAINTAINERS | 1 +
scripts/coccinelle/qobject.cocci | 13 +++++++++++++
2 files changed, 14 insertions(+)
create mode 100644 scripts/coccinelle/qobject.cocci
diff --git a/MAINTAINERS b/MAINTAINERS
index efdec47..66c9734 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1393,6 +1393,7 @@ S: Supported
F: qobject/
F: include/qapi/qmp/
X: include/qapi/qmp/dispatch.h
+F: scripts/coccinelle/qobject.cocci
F: tests/check-qdict.c
F: tests/check-qfloat.c
F: tests/check-qint.c
diff --git a/scripts/coccinelle/qobject.cocci b/scripts/coccinelle/qobject.cocci
new file mode 100644
index 0000000..aa899e2
--- /dev/null
+++ b/scripts/coccinelle/qobject.cocci
@@ -0,0 +1,13 @@
+// Use QDict macros where they make sense
+@@
+expression Obj, Key, E;
+@@
+- qdict_put_obj(Obj, Key, QOBJECT(E));
++ qdict_put(Obj, Key, E);
+
+// Use QList macros where they make sense
+@@
+expression Obj, E;
+@@
+- qlist_append_obj(Obj, QOBJECT(E));
++ qlist_append(Obj, E);
--
2.7.4
- [Qemu-devel] [PULL v3 00/28] QAPI patches for 2017-05-04, Markus Armbruster, 2017/05/09
- [Qemu-devel] [PULL v3 10/28] QemuOpts: Simplify qemu_opts_to_qdict(), Markus Armbruster, 2017/05/09
- [Qemu-devel] [PULL v3 09/28] block: Simplify bdrv_append_temp_snapshot() logic, Markus Armbruster, 2017/05/09
- [Qemu-devel] [PULL v3 07/28] qobject: Add helper macros for common scalar insertions, Markus Armbruster, 2017/05/09
- [Qemu-devel] [PULL v3 25/28] qmp-shell: add -N option to skip negotiate, Markus Armbruster, 2017/05/09
- [Qemu-devel] [PULL v3 24/28] qmp-shell: add persistent command history, Markus Armbruster, 2017/05/09
- [Qemu-devel] [PULL v3 04/28] pci: Reduce scope of error injection, Markus Armbruster, 2017/05/09
- [Qemu-devel] [PULL v3 05/28] coccinelle: Add script to remove useless QObject casts,
Markus Armbruster <=
- [Qemu-devel] [PULL v3 11/28] fdc-test: Avoid deprecated 'change' command, Markus Armbruster, 2017/05/09
- [Qemu-devel] [PULL v3 15/28] qapi: New QAPI_CLONE_MEMBERS(), Markus Armbruster, 2017/05/09
- [Qemu-devel] [PULL v3 27/28] qmp-shell: don't show version greeting if unavailable, Markus Armbruster, 2017/05/09
- [Qemu-devel] [PULL v3 01/28] tests/check-qdict: Fix missing brackets, Markus Armbruster, 2017/05/09
- [Qemu-devel] [PULL v3 19/28] sockets: Delete unused helper socket_address_crumple(), Markus Armbruster, 2017/05/09
- [Qemu-devel] [PULL v3 22/28] qapi: Document intended use of @name within alternate visits, Markus Armbruster, 2017/05/09
- [Qemu-devel] [PULL v3 06/28] qobject: Drop useless QObject casts, Markus Armbruster, 2017/05/09
- [Qemu-devel] [PULL v3 17/28] sockets: Rename SocketAddressFlat to SocketAddress, Markus Armbruster, 2017/05/09
- [Qemu-devel] [PULL v3 12/28] test-qga: Actually test 0xff sync bytes, Markus Armbruster, 2017/05/09
- [Qemu-devel] [PULL v3 21/28] qobject-input-visitor: Document full_name_nth(), Markus Armbruster, 2017/05/09