Re: [Qemu-devel] [PATCH v4 0/2] Support CPUID signature for TCG

[Daniel P. Berrange]

On Tue, May 09, 2017 at 07:05:51AM -0700, Richard Henderson wrote:
> On 05/09/2017 06:27 AM, Daniel P. Berrange wrote:
> > This enables report of a signature in CPUID for the TCG
> > interpretor.
> > 
> > Changed in v4:
> > 
> >   - Report 0x40000001 in EAX for 0x40000000 index (Eduardo)
> >   - Report all zeros for 0x40000001 index (Eduardo)
> >   - Make code style consistent when checking limits (Eduardo)
> > 
> > Changed in v3:
> > 
> >   - Simplify CPU limit code still further (Eduardo)
> > 
> > Changed in v2:
> > 
> >   - Rewrite the way we bounds check / cap the CPUID index
> >     to use a flat switch, instead of nested ifs (Eduardo)
> >   - Add a 'tcg-cpuid' property to allow it to be hidden
> >     (Eduardo)
> >   - Hide the TCG signature for old machine types
> >   - Force code to a no-op if tcg_enabled() is false (Eduardo)
> > 
> > 
> > NB, I did not introduce a general 'hypervisor-cpuid' property
> > to obsolete the existing 'kvm=off|on' -cpu property, since it
> > appears impossible to get the back compat semantics right,
> > as described in a previous reply.
> > 
> > Daniel P. Berrange (2):
> >    i386: rewrite way CPUID index is validated
> >    i386: expose "TCGTCGTCGTCG" in the 0x40000000 CPUID leaf
> 
> I probably should have commented earlier but...  what's the point?
> 
> If you want the guest os to actually do anything with this, what do
> you gain for advertising TCG over KVM?

TCG doesn't expose any of the paravirt features that KVM does, so from that
POV reporting "KVMKVMKVM" when running TCG would be wrong. As mentioned in
the 2nd patch too, every hypervisor out there reports a distinct CPUID
string, so again I think TCG should have its own identity, as it is
different CPU emulation other users of QEMU (Xen, KVM, $whatever Windows
and OS-X CPU accelerators are).

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|