[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/11] blockjob: remove iostatus_reset callback
From: |
Jeff Cody |
Subject: |
Re: [Qemu-devel] [PATCH 02/11] blockjob: remove iostatus_reset callback |
Date: |
Tue, 9 May 2017 12:26:32 -0400 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Mon, May 08, 2017 at 04:13:01PM +0200, Paolo Bonzini wrote:
> This is unused since commit 66a0fae ("blockjob: Don't touch BDS iostatus",
> 2016-05-19).
>
> Reviewed-by: Stefan Hajnoczi <address@hidden>
> Reviewed-by: John Snow <address@hidden>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> blockjob.c | 3 ---
> include/block/blockjob_int.h | 3 ---
> 2 files changed, 6 deletions(-)
>
> diff --git a/blockjob.c b/blockjob.c
> index 23022b3331..71187d0c9e 100644
> --- a/blockjob.c
> +++ b/blockjob.c
> @@ -555,9 +555,6 @@ bool block_job_is_cancelled(BlockJob *job)
> void block_job_iostatus_reset(BlockJob *job)
> {
> job->iostatus = BLOCK_DEVICE_IO_STATUS_OK;
> - if (job->driver->iostatus_reset) {
> - job->driver->iostatus_reset(job);
> - }
> }
>
> static int block_job_finish_sync(BlockJob *job,
> diff --git a/include/block/blockjob_int.h b/include/block/blockjob_int.h
> index 3f86cc5acc..bfcc5d1241 100644
> --- a/include/block/blockjob_int.h
> +++ b/include/block/blockjob_int.h
> @@ -44,9 +44,6 @@ struct BlockJobDriver {
> /** Optional callback for job types that support setting a speed limit */
> void (*set_speed)(BlockJob *job, int64_t speed, Error **errp);
>
> - /** Optional callback for job types that need to forward I/O status
> reset */
> - void (*iostatus_reset)(BlockJob *job);
> -
> /** Mandatory: Entrypoint for the Coroutine. */
> CoroutineEntry *start;
>
> --
> 2.12.2
>
>
Reviewed-by: Jeff Cody <address@hidden>
- [Qemu-devel] [PATCH v2 00/11] Preparation for block job mutex, Paolo Bonzini, 2017/05/08
- [Qemu-devel] [PATCH 01/11] blockjob: remove unnecessary check, Paolo Bonzini, 2017/05/08
- [Qemu-devel] [PATCH 02/11] blockjob: remove iostatus_reset callback, Paolo Bonzini, 2017/05/08
- Re: [Qemu-devel] [PATCH 02/11] blockjob: remove iostatus_reset callback,
Jeff Cody <=
- [Qemu-devel] [PATCH 03/11] blockjob: introduce block_job_early_fail, Paolo Bonzini, 2017/05/08
- [Qemu-devel] [PATCH 04/11] blockjob: introduce block_job_pause/resume_all, Paolo Bonzini, 2017/05/08
- [Qemu-devel] [PATCH 06/11] blockjob: move iostatus reset inside block_job_user_resume, Paolo Bonzini, 2017/05/08
- [Qemu-devel] [PATCH 08/11] blockjob: group BlockJob transaction functions together, Paolo Bonzini, 2017/05/08
- [Qemu-devel] [PATCH 05/11] blockjob: separate monitor and blockjob APIs, Paolo Bonzini, 2017/05/08