[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/3] xen/9pfs: fix two resource leaks on erro
From: |
Stefano Stabellini |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/3] xen/9pfs: fix two resource leaks on error paths, discovered by Coverity |
Date: |
Tue, 9 May 2017 12:47:54 -0700 (PDT) |
User-agent: |
Alpine 2.10 (DEB 1266 2009-07-14) |
On Tue, 9 May 2017, Eric Blake wrote:
> On 05/09/2017 02:20 PM, Eric Blake wrote:
> > On 05/09/2017 02:04 PM, Stefano Stabellini wrote:
> >> CID: 1374836
> >>
> >> Signed-off-by: Stefano Stabellini <address@hidden>
> >> CC: address@hidden
> >> CC: address@hidden
> >> CC: address@hidden
> >> ---
> >> hw/9pfs/xen-9p-backend.c | 2 ++
> >> 1 file changed, 2 insertions(+)
> >
> > Reviewed-by: Eric Blake <address@hidden>
>
> By the way, you forgot to send a 0/3 cover letter (at least, there was
> no In-Reply-To: header in your 1/3 mail). That makes it harder to
> automate handling of your series; I was going to reply to the series as
> a whole.
>
> While it is inconvenient for human readers, it is even worse for some of
> the automated patch tooling we have that expects cover letters for any
> multi-patch series. More patch submission tips at
> http://wiki.qemu.org/Contribute/SubmitAPatch include how to use 'git
> config' to automate the creation of a cover letter.
Sorry about that, and thanks for the review.
- [Qemu-devel] [PATCH v2 2/3] Check the return value of fcntl in qemu_set_cloexec, (continued)
- [Qemu-devel] [PATCH v2 2/3] Check the return value of fcntl in qemu_set_cloexec, Stefano Stabellini, 2017/05/09
- [Qemu-devel] [PATCH v2 3/3] xen: call qemu_set_cloexec instead of fcntl, Stefano Stabellini, 2017/05/09
- Re: [Qemu-devel] [PATCH v2 1/3] xen/9pfs: fix two resource leaks on error paths, discovered by Coverity, Eric Blake, 2017/05/09
- Re: [Qemu-devel] [PATCH v2 1/3] xen/9pfs: fix two resource leaks on error paths, discovered by Coverity, Greg Kurz, 2017/05/09