Re: [Qemu-devel] [PULL 00/22] ppc-for-2.10 queue 20170510

[David Gibson]

On Wed, May 10, 2017 at 12:50:29AM -0700, address@hidden wrote:
> Hi,
> 
> This series seems to have some coding style problems. See output below for
> more information:
> 
> Message-id: address@hidden
> Type: series
> Subject: [Qemu-devel] [PULL 00/22] ppc-for-2.10 queue 20170510
> 
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> 
> BASE=base
> n=1
> total=$(git log --oneline $BASE.. | wc -l)
> failed=0
> 
> git config --local diff.renamelimit 0
> git config --local diff.renames True
> 
> commits="$(git log --format=%H --reverse $BASE..)"
> for c in $commits; do
>     echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
>     if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; 
> then
>         failed=1
>         echo
>     fi
>     n=$((n+1))
> done
> 
> exit $failed
> === TEST SCRIPT END ===
> 
> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
> Switched to a new branch 'test'
> 1b70f29 pnv: Fix build failures on some host platforms
> 86671f8 target/ppc: Allow workarounds for POWER9 DD1
> 6cedee8 spapr: Don't accidentally advertise HTM support on POWER9
> 6977773 ppc: xics: fix compilation with CentOS 6
> eafc8f5 target/ppc: Enable RADIX mmu mode for pseries TCG guest
> 0695293 target/ppc: Implement ISA V3.00 radix page fault handler
> 44c9403 target/ppc: Change tlbie invalid fields for POWER9 support
> 9b09287 target/ppc: Update tlbie to check privilege level based on GTSE
> d1a36ba target/ppc: Set UPRT and GTSE on all cpus in H_REGISTER_PROCESS_TABLE
> 7cf9c6f ppc: add qemu_vga.ndrv ROM to fw_cfg interface for NewWorld Macs
> dd211ca ppc: add qemu_vga.ndrv ROM to fw_cfg interface for OldWorld Macs
> 757323f Add QemuMacDrivers qemu_vga.ndrv revision d4e7d7a built as submodule
> 636240c Add QemuMacDrivers as submodule
> bd86886 ppc/xics: preserve P and Q bits for KVM IRQs
> c769966 ppc/xics: Fix stale irq->status bits after get
> fe7ce46 target/ppc: do not reset reserve_addr in exec_enter
> 48eb3bf tcg: enable MTTCG by default for PPC64 on x86
> 46bdb83 cpus: Fix CPU unplug for MTTCG
> 64d1b41 target/ppc: Generate fence operations
> 688eb24 cputlb: handle first atomic write to the page
> 625734c target/ppc: Emulate LL/SC using cmpxchg helpers
> d736912 ppc/pnv: restrict BMC object to the BMC simulator
> 
> === OUTPUT BEGIN ===
> Checking PATCH 1/22: ppc/pnv: restrict BMC object to the BMC simulator...
> Checking PATCH 2/22: target/ppc: Emulate LL/SC using cmpxchg helpers...
> Checking PATCH 3/22: cputlb: handle first atomic write to the page...
> Checking PATCH 4/22: target/ppc: Generate fence operations...
> Checking PATCH 5/22: cpus: Fix CPU unplug for MTTCG...
> Checking PATCH 6/22: tcg: enable MTTCG by default for PPC64 on x86...
> Checking PATCH 7/22: target/ppc: do not reset reserve_addr in exec_enter...
> Checking PATCH 8/22: ppc/xics: Fix stale irq->status bits after get...
> Checking PATCH 9/22: ppc/xics: preserve P and Q bits for KVM IRQs...
> Checking PATCH 10/22: Add QemuMacDrivers as submodule...
> Checking PATCH 11/22: Add QemuMacDrivers qemu_vga.ndrv revision d4e7d7a built 
> as submodule...
> Checking PATCH 12/22: ppc: add qemu_vga.ndrv ROM to fw_cfg interface for 
> OldWorld Macs...
> Checking PATCH 13/22: ppc: add qemu_vga.ndrv ROM to fw_cfg interface for 
> NewWorld Macs...
> Checking PATCH 14/22: target/ppc: Set UPRT and GTSE on all cpus in 
> H_REGISTER_PROCESS_TABLE...
> Checking PATCH 15/22: target/ppc: Update tlbie to check privilege level based 
> on GTSE...
> Checking PATCH 16/22: target/ppc: Change tlbie invalid fields for POWER9 
> support...
> Checking PATCH 17/22: target/ppc: Implement ISA V3.00 radix page fault 
> handler...
> ERROR: Macros with complex values should be enclosed in parenthesis
> #413: FILE: target/ppc/mmu-radix64.h:19:
> +#define PRTBE_R_GET_RTS(rts)    (((rts >> 58) & 0x18) | ((rts >> 5) & 0x7)) 
> + 31

Crud.  that's actually an important one, I should have caught it.

> total: 1 errors, 0 warnings, 373 lines checked
> 
> Your patch has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 
> Checking PATCH 18/22: target/ppc: Enable RADIX mmu mode for pseries TCG 
> guest...
> Checking PATCH 19/22: ppc: xics: fix compilation with CentOS 6...
> Checking PATCH 20/22: spapr: Don't accidentally advertise HTM support on 
> POWER9...
> Checking PATCH 21/22: target/ppc: Allow workarounds for POWER9 DD1...
> Checking PATCH 22/22: pnv: Fix build failures on some host platforms...
> === OUTPUT END ===
> 
> Test command exited with code: 1
> 
> 
> ---
> Email generated automatically by Patchew [http://patchew.org/].
> Please send your feedback to address@hidden

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

signature.asc
Description: PGP signature