[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 4/6] target/s390x: Implement LOAD PAIR DISJOI
From: |
Éric Bischoff |
Subject: |
Re: [Qemu-devel] [PATCH v3 4/6] target/s390x: Implement LOAD PAIR DISJOINT |
Date: |
Wed, 10 May 2017 19:13:05 +0200 |
User-agent: |
KMail/4.14.10 (Linux/4.4.62-18.6-default; KDE/4.14.25; x86_64; ; ) |
Le mercredi 10 mai 2017, 12:16:20 Aurelien Jarno a écrit :
> > + /* In a parallel context, stop the world and single step. */
> > + if (parallel_cpus) {
> > + potential_page_fault(s);
> > + gen_helper_exit_atomic(cpu_env);
> > + return EXIT_NORETURN;
> > + }
>
> One small additional comment about this patch I haven't spotted at the
> first review. The exit_atomic helper is properly restoring the CPU state
> passing the return address to cpu_loop_exit_atomic, so I believe the
> potential_page_fault call is not necessary. That said, it doesn't hurt
> either.
Merci pour la relecture Aurélien.
Richard, what do we do? We remove the potential_page_fault(s); or not?
--
Éric Bischoff
[Qemu-devel] [PATCH v3 5/6] target/s390x: Use atomic operations for COMPARE SWAP, Richard Henderson, 2017/05/09
[Qemu-devel] [PATCH v3 6/6] target/s390x: Use atomic operations for LOAD AND OP, Richard Henderson, 2017/05/09
Re: [Qemu-devel] [PATCH v3 0/6] target/s390x patches, no-reply, 2017/05/09