[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH 5/7] curl: convert CURLAIOCB to byt
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH 5/7] curl: convert CURLAIOCB to byte values |
|
Date: |
Wed, 10 May 2017 13:37:23 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 05/10/2017 12:36 PM, Max Reitz wrote:
> On a very surprised level: Why does curl return the content length as a
> double?! I can't think of a reason where that might be a good idea. If
> your integer no longer fits into a uin64_t, the double will be inexact,
> so it pretty much is useless, too...
Not to mention: NO ONE has off_t larger than 63 bits (there physically
is not that much storage around!), so a signed 64-bit integer should
always be sufficient, rather than artificially limiting exact answers to
53 bits of precision via a double.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 2/7] curl: never invoke callbacks with s->mutex held, (continued)
- [Qemu-devel] [PATCH 4/7] curl: split curl_find_state/curl_init_state, Paolo Bonzini, 2017/05/10
- [Qemu-devel] [PATCH 7/7] curl: do not do aio_poll when waiting for a free CURLState, Paolo Bonzini, 2017/05/10
- [Qemu-devel] [PATCH 5/7] curl: convert CURLAIOCB to byte values, Paolo Bonzini, 2017/05/10
- [Qemu-devel] [PATCH 6/7] curl: convert readv to coroutines, Paolo Bonzini, 2017/05/10
- Re: [Qemu-devel] [PATCH v2 0/7] curl: locking cleanups/fixes, coroutine conversion, remove aio_poll, no-reply, 2017/05/10
- Re: [Qemu-devel] [PATCH v2 0/7] curl: locking cleanups/fixes, coroutine conversion, remove aio_poll, Richard W.M. Jones, 2017/05/10