[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 4/4] utils: remove assert in size_to_str()
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v7 4/4] utils: remove assert in size_to_str() |
|
Date: |
Thu, 11 May 2017 10:03:20 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 05/11/2017 07:22 AM, Peter Xu wrote:
> It's not very safe to assert in size_to_str(). Let's be inclusive.
>
> It naturally allows negative values. Now it won't even limit on the
> size, as long as double would allow.
>
> Signed-off-by: Peter Xu <address@hidden>
> ---
> util/cutils.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
Since you just introduced this in 2/4, I'd rather see the two squashed
together if we decide this is the interface we want to support.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature