qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 1/4] throttle: factor out duplicate code


From: Pradeep Jagadeesh
Subject: Re: [Qemu-devel] [PATCH v4 1/4] throttle: factor out duplicate code
Date: Thu, 11 May 2017 18:12:30 +0200
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1

On 5/10/2017 9:48 PM, Eric Blake wrote:
On 05/10/2017 10:27 AM, Pradeep Jagadeesh wrote:


Isn't it a bit overkill to introduce a new file for a single function ?
Maybe you could simply move this to util/throttle.c ?

OK, but I will add one more function later patch. Still do you think
better to move to util/thottle.c?

As long as util/throttle.c is not already huge, adding multiple new
functions to that file over the course of the series should be just fine.
OK, I will use util/throttle.c.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]