[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 1/3] migration: Create block capabilities for shared
From: |
Juan Quintela |
Subject: |
[Qemu-devel] [PATCH 1/3] migration: Create block capabilities for shared and enable |
Date: |
Thu, 11 May 2017 18:32:26 +0200 |
Those two capabilities were added through the command line. Notice that
we just created them. This is just the boilerplate.
Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
--
Make migrate_set_block_* take a boolean argument.
Signed-off-by: Juan Quintela <address@hidden>
---
include/migration/block.h | 3 +++
include/migration/migration.h | 3 +++
migration/migration.c | 36 ++++++++++++++++++++++++++++++++++++
qapi-schema.json | 7 ++++++-
4 files changed, 48 insertions(+), 1 deletion(-)
diff --git a/include/migration/block.h b/include/migration/block.h
index 41a1ac8..5b3f1a5 100644
--- a/include/migration/block.h
+++ b/include/migration/block.h
@@ -20,4 +20,7 @@ uint64_t blk_mig_bytes_transferred(void);
uint64_t blk_mig_bytes_remaining(void);
uint64_t blk_mig_bytes_total(void);
+void migrate_set_block_shared(MigrationState *s, bool value);
+void migrate_set_block_enabled(MigrationState *s, bool value);
+
#endif /* MIGRATION_BLOCK_H */
diff --git a/include/migration/migration.h b/include/migration/migration.h
index 0c9b6af..30c2913 100644
--- a/include/migration/migration.h
+++ b/include/migration/migration.h
@@ -305,6 +305,9 @@ bool migrate_colo_enabled(void);
int64_t xbzrle_cache_resize(int64_t new_size);
+bool migrate_use_block_enabled(void);
+bool migrate_use_block_shared(void);
+
bool migrate_use_compression(void);
int migrate_compress_level(void);
int migrate_compress_threads(void);
diff --git a/migration/migration.c b/migration/migration.c
index fe62f15..2f981aa 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -1195,6 +1195,16 @@ bool migration_is_blocked(Error **errp)
return false;
}
+void migrate_set_block_shared(MigrationState *s, bool value)
+{
+ s->enabled_capabilities[MIGRATION_CAPABILITY_BLOCK_SHARED] = value;
+}
+
+void migrate_set_block_enabled(MigrationState *s, bool value)
+{
+ s->enabled_capabilities[MIGRATION_CAPABILITY_BLOCK_ENABLED] = value;
+}
+
void qmp_migrate(const char *uri, bool has_blk, bool blk,
bool has_inc, bool inc, bool has_detach, bool detach,
Error **errp)
@@ -1224,6 +1234,14 @@ void qmp_migrate(const char *uri, bool has_blk, bool blk,
s = migrate_init(¶ms);
+ if (has_blk && blk) {
+ migrate_set_block_enabled(s, true);
+ }
+
+ if (has_inc && inc) {
+ migrate_set_block_shared(s, true);
+ }
+
if (strstart(uri, "tcp:", &p)) {
tcp_start_outgoing_migration(s, p, &local_err);
#ifdef CONFIG_RDMA
@@ -1419,6 +1437,24 @@ int64_t migrate_xbzrle_cache_size(void)
return s->xbzrle_cache_size;
}
+bool migrate_use_block_enabled(void)
+{
+ MigrationState *s;
+
+ s = migrate_get_current();
+
+ return s->enabled_capabilities[MIGRATION_CAPABILITY_BLOCK_ENABLED];
+}
+
+bool migrate_use_block_shared(void)
+{
+ MigrationState *s;
+
+ s = migrate_get_current();
+
+ return s->enabled_capabilities[MIGRATION_CAPABILITY_BLOCK_SHARED];
+}
+
/* migration thread support */
/*
* Something bad happened to the RP stream, mark an error
diff --git a/qapi-schema.json b/qapi-schema.json
index 5728b7f..109852e 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -894,11 +894,16 @@
# @release-ram: if enabled, qemu will free the migrated ram pages on the source
# during postcopy-ram migration. (since 2.9)
#
+# @block-enabled: enable block migration (Since 2.10)
+#
+# @block-shared: enable block shared migration (Since 2.10)
+#
# Since: 1.2
##
{ 'enum': 'MigrationCapability',
'data': ['xbzrle', 'rdma-pin-all', 'auto-converge', 'zero-blocks',
- 'compress', 'events', 'postcopy-ram', 'x-colo', 'release-ram'] }
+ 'compress', 'events', 'postcopy-ram', 'x-colo', 'release-ram',
+ 'block-enabled', 'block-shared' ] }
##
# @MigrationCapabilityStatus:
--
2.9.3
- [Qemu-devel] [PATCH v2 0/3] Remove old MigrationParams, Juan Quintela, 2017/05/11
- [Qemu-devel] [PATCH 1/3] migration: Create block capabilities for shared and enable,
Juan Quintela <=
- Re: [Qemu-devel] [PATCH 1/3] migration: Create block capabilities for shared and enable, Eric Blake, 2017/05/12
- Re: [Qemu-devel] [PATCH 1/3] migration: Create block capabilities for shared and enable, Juan Quintela, 2017/05/15
- Re: [Qemu-devel] [PATCH 1/3] migration: Create block capabilities for shared and enable, Dr. David Alan Gilbert, 2017/05/15
- Re: [Qemu-devel] [PATCH 1/3] migration: Create block capabilities for shared and enable, Eric Blake, 2017/05/15
- Re: [Qemu-devel] [PATCH 1/3] migration: Create block capabilities for shared and enable, Markus Armbruster, 2017/05/15
- Re: [Qemu-devel] [PATCH 1/3] migration: Create block capabilities for shared and enable, Juan Quintela, 2017/05/15
- Re: [Qemu-devel] [PATCH 1/3] migration: Create block capabilities for shared and enable, Markus Armbruster, 2017/05/16
- Re: [Qemu-devel] [PATCH 1/3] migration: Create block capabilities for shared and enable, Juan Quintela, 2017/05/15
[Qemu-devel] [PATCH 2/3] migration: Remove use of old MigrationParams, Juan Quintela, 2017/05/11