[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-ppc] [PATCH 7/8] target/ppc: optimize various fun
|
From: |
David Gibson |
|
Subject: |
Re: [Qemu-devel] [Qemu-ppc] [PATCH 7/8] target/ppc: optimize various functions using extract op |
|
Date: |
Fri, 12 May 2017 15:13:13 +1000 |
|
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Thu, May 11, 2017 at 10:46:01AM +0200, Laurent Vivier wrote:
> On 11/05/2017 02:41, David Gibson wrote:
> > On Wed, May 10, 2017 at 05:05:34PM -0300, Philippe Mathieu-Daudé wrote:
> >> Applied using Coccinelle script.
> >>
> >> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> >
> > Reviewed-by: David Gibson <address@hidden>
>
> David, look at Nikunj's comments: only the two first changes are correct.
>
> 'andi" uses a mask, but extract uses a 'width'. Philippe's changes work
> only when mask = 1.
Oops, that was sloppy of me, sorry.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- [Qemu-devel] [PATCH 4/8] target/cris: optimize gen_swapb() using extract op, (continued)
- [Qemu-devel] [PATCH 4/8] target/cris: optimize gen_swapb() using extract op, Philippe Mathieu-Daudé, 2017/05/10
- [Qemu-devel] [PATCH 5/8] target/m68k: optimize bcd_flags() using extract op, Philippe Mathieu-Daudé, 2017/05/10
- [Qemu-devel] [PATCH 6/8] target/mips: optimize bshfl() using extract op, Philippe Mathieu-Daudé, 2017/05/10
- [Qemu-devel] [PATCH 7/8] target/ppc: optimize various functions using extract op, Philippe Mathieu-Daudé, 2017/05/10
- Re: [Qemu-devel] [PATCH 7/8] target/ppc: optimize various functions using extract op, Nikunj A Dadhania, 2017/05/11
[Qemu-devel] [PATCH 8/8] target/sparc: optimize various functions using extract op, Philippe Mathieu-Daudé, 2017/05/10
Re: [Qemu-devel] [PATCH 0/8] optimize various tcg_gen() functions using extract op, no-reply, 2017/05/10