qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCHv6 0/5] HPT resizing for pseries guests (qemu par


From: no-reply
Subject: Re: [Qemu-devel] [PATCHv6 0/5] HPT resizing for pseries guests (qemu part)
Date: Thu, 11 May 2017 22:44:32 -0700 (PDT)

Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCHv6 0/5] HPT resizing for pseries guests (qemu part)
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
bc86869 pseries: Allow HPT resizing with KVM
1b07d16 pseries: Use smaller default hash page tables when guest can resize
5b59386 pseries: Enable HPT resizing for 2.10
61cecbb pseries: Implement HPT resizing
fe4fe32 pseries: Stubs for HPT resizing

=== OUTPUT BEGIN ===
Checking PATCH 1/5: pseries: Stubs for HPT resizing...
WARNING: line over 80 characters
#278: FILE: target/ppc/kvm.c:2719:
+    error_setg(errp, "Hash page table resizing not available with this KVM 
version");

total: 0 errors, 1 warnings, 239 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 2/5: pseries: Implement HPT resizing...
ERROR: spaces required around that '/' (ctx:VxV)
#237: FILE: hw/ppc/spapr_hcall.c:516:
+    stq_p(addr + HASH_PTE_SIZE_64/2, pte1);
                                  ^

ERROR: spaces required around that '*' (ctx:WxV)
#339: FILE: hw/ppc/spapr_hcall.c:618:
+        hwaddr ptex = pteg *HPTES_PER_GROUP;
                            ^

total: 2 errors, 0 warnings, 401 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 3/5: pseries: Enable HPT resizing for 2.10...
Checking PATCH 4/5: pseries: Use smaller default hash page tables when guest 
can resize...
Checking PATCH 5/5: pseries: Allow HPT resizing with KVM...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]