Re: [Qemu-devel] [Qemu-ppc] [PATCH v9 6/6] migration: spapr: migrate pending_events of spapr state

[David Gibson]

On Fri, May 12, 2017 at 05:02:44PM -0300, Daniel Henrique Barboza wrote:
> 
> 
> On 05/12/2017 03:28 AM, David Gibson wrote:
> > On Fri, May 05, 2017 at 05:47:46PM -0300, Daniel Henrique Barboza wrote:
> > > From: Jianjun Duan <address@hidden>
> > > 
> > > In racing situations between hotplug events and migration operation,
> > > a rtas hotplug event could have not yet be delivered to the source
> > > guest when migration is started. In this case the pending_events of
> > > spapr state need be transmitted to the target so that the hotplug
> > > event can be finished on the target.
> > > 
> > > All the different fields of the events are encoded as defined by
> > > PAPR. We can migrate them as uint8_t binary stream without any
> > > concerns about data padding or endianess.
> > > 
> > > pending_events is put in a subsection in the spapr state VMSD to make
> > > sure migration across different versions is not broken.
> > > 
> > > Signed-off-by: Jianjun Duan <address@hidden>
> > > Signed-off-by: Daniel Henrique Barboza <address@hidden>
> > This seems like it's probably a good idea, even independent of the
> > hotplug migration stuff.  I suspect there are other races where we
> > could lose a shutdown event or similar if there's a migration.
> Perhaps we can detach this patch (and the ccs_list one) from this
> series and evaluate them separately?

Fine by me for this patch.  Not so much with the ccs one, because
migrating the ccs stuff really doesn't make sense without properly
migrating the rest of the drc state.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

signature.asc
Description: PGP signature