[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/4] exec: rename resolve_subpage
|
From: |
Peter Xu |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/4] exec: rename resolve_subpage |
|
Date: |
Mon, 15 May 2017 20:16:20 +0800 |
|
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Mon, May 15, 2017 at 11:03:49AM +0200, Paolo Bonzini wrote:
>
>
> On 15/05/2017 10:50, Peter Xu wrote:
> > It is not easy for people to know "what this parameter does" before
> > knowing "what is subpage". Let's use "is_mmio" to make it easier to
> > understand.
> >
> > Signed-off-by: Peter Xu <address@hidden>
>
> Maybe invert the direction and call it for_iotlb?
I wasn't aware that tcg is using resolve_subpage==false always. Then
at least is_mmio does not suite here. I am not sure whether for-iotlb
suites here either... So maybe I will just drop this patch as well,
just like patch 3.
Thanks for reviewing it!
--
Peter Xu
- [Qemu-devel] [PATCH 0/4] exec: address space translation cleanups, Peter Xu, 2017/05/15
- [Qemu-devel] [PATCH 1/4] exec: simplify phys_page_find() params, Peter Xu, 2017/05/15
- [Qemu-devel] [PATCH 2/4] exec: rename resolve_subpage, Peter Xu, 2017/05/15
- [Qemu-devel] [PATCH 3/4] exec: further use is_mmio, Peter Xu, 2017/05/15
- [Qemu-devel] [PATCH 4/4] exec: abstract address_space_do_translate(), Peter Xu, 2017/05/15
- Re: [Qemu-devel] [PATCH 0/4] exec: address space translation cleanups, Maxime Coquelin, 2017/05/16