[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-arm] [Qemu-devel PATCH 1/5] msf2: Add Smartfusion
|
From: |
sundeep subbaraya |
|
Subject: |
Re: [Qemu-devel] [Qemu-arm] [Qemu-devel PATCH 1/5] msf2: Add Smartfusion2 System timer |
|
Date: |
Tue, 16 May 2017 12:11:41 +0530 |
Hi Philippe,
On Mon, May 15, 2017 at 5:22 PM, Philippe Mathieu-Daudé <address@hidden>
wrote:
> Hi Subbaraya,
>
> + if (value & TIMER_MODE) {
>>> + qemu_log_mask(LOG_UNIMP, "64-bit mode not supported\n");
>>>
>>
>> No need of trailing '\n', be more specific, something like:
>>
>> qemu_log_mask(LOG_UNIMP, TYPE_MSF2_TIMER ": 64-bit mode not
>> supported");
>>
>
> I mistaken with error_report(), qemu_log_mask() does use trailing newline,
> sorry!
>
thats ok :)
Thanks,
Sundeep
>
> Phil.
>
[Qemu-devel] [Qemu-devel PATCH 2/5] msf2: Microsemi Smartfusion2 System Register block., Subbaraya Sundeep, 2017/05/09
[Qemu-devel] [Qemu-devel PATCH 3/5] msf2: Add Smartfusion2 SPI controller, Subbaraya Sundeep, 2017/05/09
[Qemu-devel] [Qemu-devel PATCH 5/5] msf2: Add Emcraft's Smartfusion2 SOM kit., Subbaraya Sundeep, 2017/05/09