Re: [Qemu-devel] [PATCH] sockets: Plug memory leak in socket_address_flatten()

[Markus Armbruster]

Eric Blake <address@hidden> writes:

> On 05/15/2017 11:39 AM, Markus Armbruster wrote:
>> socket_address_flatten() leaks a SocketAddress when its argument is
>> null.  Happens when opening a ChardevBackend of type 'udp' that is
>> configured without a local address.  Screwed up in commit bd269ebc due
>> to last minute semantic conflict resolution.  Spotted by Coverity.
>> 
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>>  util/qemu-sockets.c | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> Reviewed-by: Eric Blake <address@hidden>
>
> Matches the fix I had proposed here against the v2 pull request:
> https://lists.gnu.org/archive/html/qemu-devel/2017-05/msg01825.html
>
> I guess in the confusion of the rebasing, you didn't quite implement it
> in v3 the way I had proposed.

I had started to resolve conflicts myself when the message carrying your
solution arrived, and I obviously screwed up merging it into my unclean
tree.  In other words: it's all my fault.