[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 4/5] shutdown: Add source information to SHUT
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v9 4/5] shutdown: Add source information to SHUTDOWN and RESET |
Date: |
Tue, 16 May 2017 10:46:57 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Eric Blake <address@hidden> writes:
> Time to wire up all the call sites that request a shutdown or
> reset to use the enum added in the previous patch.
>
> It would have been less churn to keep the common case with no
> arguments as meaning guest-triggered, and only modified the
> host-triggered code paths, via a wrapper function, but then we'd
> still have to audit that I didn't miss any host-triggered spots;
> changing the signature forces us to double-check that I correctly
> categorized all callers.
>
> Since command line options can change whether a guest reset request
> causes an actual reset vs. a shutdown, it's easy to also add the
> information to reset requests.
>
> Signed-off-by: Eric Blake <address@hidden>
> Acked-by: David Gibson <address@hidden> [ppc parts]
> Reviewed-by: Mark Cave-Ayland <address@hidden> [SPARC part]
> Reviewed-by: Cornelia Huck <address@hidden> [s390x parts]
>
> ---
> v8: rebase later in series
That turned out nicely. Thanks!
Reviewed-by: Markus Armbruster <address@hidden>
- [Qemu-devel] [PATCH v9 0/5] event: Add source information to SHUTDOWN, Eric Blake, 2017/05/15
- [Qemu-devel] [PATCH v9 1/5] shutdown: Simplify shutdown_signal, Eric Blake, 2017/05/15
- [Qemu-devel] [PATCH v9 2/5] shutdown: Prepare for use of an enum in reset/shutdown_request, Eric Blake, 2017/05/15
- [Qemu-devel] [PATCH v9 3/5] shutdown: Preserve shutdown cause through replay, Eric Blake, 2017/05/15
- [Qemu-devel] [PATCH v9 5/5] shutdown: Expose bool cause in SHUTDOWN and RESET events, Eric Blake, 2017/05/15
- [Qemu-devel] [PATCH v9 4/5] shutdown: Add source information to SHUTDOWN and RESET, Eric Blake, 2017/05/15
- Re: [Qemu-devel] [PATCH v9 4/5] shutdown: Add source information to SHUTDOWN and RESET,
Markus Armbruster <=
- Re: [Qemu-devel] [PATCH v9 0/5] event: Add source information to SHUTDOWN, Markus Armbruster, 2017/05/16